Sign upLogin

cogniteev/easy-upgrade

View on GitHub
Star

Showing 15 of 15 total issues

File api.py has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import inspect
import logging
import operator

import pkg_resources
Severity: Minor
Found in easy_upgrade/api.py - About 3 hrs to fix

    Function get_outdated_packages has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_outdated_packages(self):
        for pkg in self.get_packages_version():
            versions = pkg['versions']
            outdated = False
            installed = versions.get('installed')
    Severity: Minor
    Found in easy_upgrade/api.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function find_executable has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def find_executable(*names, **kwargs):
    for name in names:
        if osp.isabs(name):
            return name
        for path in os.environ['PATH'].split(os.pathsep):
    Severity: Minor
    Found in easy_upgrade/toolbox.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_latest_release has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_latest_release(self):
        result = None
        release_date = None

        releases = self.get_releases()
    Severity: Minor
    Found in easy_upgrade/lib/github.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __get_raw_config has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def __get_raw_config(self, config_key, default, unique):
        raw_configs = self.get(config_key)
        if raw_configs is None:
            if default is not None:
                return default
    Severity: Minor
    Found in easy_upgrade/api.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function install_outdated_packages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def install_outdated_packages(config, release=None, **kwargs):
    eu = EasyUpgrade.from_yaml(config)
    if len(release) == 0:
        for provider in eu.providers.values():
            provider.install()
    Severity: Minor
    Found in easy_upgrade/cli.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function list_outdated_packages has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def list_outdated_packages(config, all_packages=False, **kwargs):
    eu = EasyUpgrade.from_yaml(config)
    method = eu.get_outdated_packages
    if all_packages:
        method = eu.get_packages_version
    Severity: Minor
    Found in easy_upgrade/cli.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function register has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def register(cls, base_name, action_cls, name, providers):
    Severity: Minor
    Found in easy_upgrade/api.py - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if unique:
                if len(raw_configs) != 1:
                    raise Exception(
                        "Release config key '{}' ".format(config_key) +
      Severity: Minor
      Found in easy_upgrade/api.py and 1 other location - About 35 mins to fix
      easy_upgrade/api.py on lines 257..259

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function get_action_providers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_action_providers(cls, new_type, attrs):
        providers = attrs.get('providers')
        if 'providers' not in attrs:
            classes = [new_type]
            while providers is None and any(classes):
      Severity: Minor
      Found in easy_upgrade/api.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fetch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def fetch(self, output_directory):
        name = self.get('name')
        if name is not None:
            name = self.jinja_eval(name)
        getattr(self, 'grelease')
      Severity: Minor
      Found in easy_upgrade/lib/github.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if len(config) != 1:
                raise Exception(
                    "Release config-key '{}' ".format(config_key) +
      Severity: Minor
      Found in easy_upgrade/api.py and 1 other location - About 35 mins to fix
      easy_upgrade/api.py on lines 229..232

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def run(args=None):
    parser = argparse.ArgumentParser(
    )
    from . import __version__
    version = '.'.join(map(str, __version__))
      Severity: Minor
      Found in easy_upgrade/cli.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __extract_action has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def __extract_action(self, config_key, base_action_cls,
                         unique=True, default=None):
        raw_configs = self.__get_raw_config(config_key, default, unique)
        actions = []
        for config in raw_configs:
      Severity: Minor
      Found in easy_upgrade/api.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_action has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_action(cls, base, name, provider):
        if isinstance(provider, ReleaseProvider):
            provider = provider.name
        base = base.__name__ if inspect.isclass(base) else base
        actions = cls.actions.get(base, {})
      Severity: Minor
      Found in easy_upgrade/api.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language