Sign upLogin

coi-gov-pl/puppet-jboss

View on GitHub
Star
lib/puppet_x/coi/jboss/provider/datasource.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File datasource.rb has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative '../configuration'

# A class for JBoss datasource provider
module PuppetX::Coi::Jboss::Provider::Datasource
  include PuppetX::Coi::Jboss::Constants
Severity: Minor
Found in lib/puppet_x/coi/jboss/provider/datasource.rb - About 5 hrs to fix

    Method write_connection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Wontfix

      def write_connection(property, value)
    if xa?
      if h2?
        write_xa_property 'URL', connection_url
      else
    Severity: Minor
    Found in lib/puppet_x/coi/jboss/provider/datasource.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method connection_url has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Wontfix

      def connection_url
    scheme = @resource[:jdbcscheme]
    host = @resource[:host]
    port = @resource[:port]
    dbname = @resource[:dbname]
    Severity: Minor
    Found in lib/puppet_x/coi/jboss/provider/datasource.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare_resource has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def prepare_resource
    @resource = {} if @resource.nil?
    @resource[:name] = @property_hash[:name] if @resource[:name].nil?
    @resource[:controller] = controller if @resource[:controller].nil?
    @resource[:runasdomain] = runasdomain if @resource[:runasdomain].nil?
    Severity: Minor
    Found in lib/puppet_x/coi/jboss/provider/datasource.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status