Sign upLogin

collectiveidea/travis_bundle_cache

View on GitHub
Star

Showing 2 of 2 total issues

Method run_command has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def run_command(cmd, opts = {})
      tries = 1
      puts "Running: #{cmd}"
      while true
        IO.popen(cmd) do |f|
Severity: Minor
Found in lib/travis_bundle_cache/cache.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cache_bundle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def cache_bundle
      puts "Checking for changes"
      @bundle_digest = Digest::SHA2.file(@lock_file).hexdigest
      @old_digest    = File.exists?(@old_digest_filename) ? File.read(@old_digest_filename) : ""
Severity: Minor
Found in lib/travis_bundle_cache/cache.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language