Sign upLogin

collizo4sky/omnipay-2checkout

View on GitHub
Star

Showing 8 of 8 total issues

Gateway has 40 functions (exceeds 20 allowed). Consider refactoring.
Open

class Gateway extends AbstractGateway
{
    public function getName()
    {
        return 'TwoCheckoutPlus';
Severity: Minor
Found in src/Gateway.php - About 5 hrs to fix

    AbstractRequest has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AbstractRequest extends BaseAbstractRequest
{
    public function getCart()
    {
        return $this->getParameter('cart');
    Severity: Minor
    Found in src/Message/AbstractRequest.php - About 4 hrs to fix

      Function getData has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getData()
    {
        $this->validate('accountNumber', 'returnUrl');

        $data = array();
      Severity: Minor
      Found in src/Message/PurchaseRequest.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getData has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getData()
    {
        $this->validate('accountNumber', 'returnUrl');

        $data = array();
      Severity: Major
      Found in src/Message/PurchaseRequest.php - About 2 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function sendData($data)
    {
        $payload = $data;
        unset($payload['admin_username']);
        unset($payload['admin_password']);
        Severity: Major
        Found in src/Message/RefundRequest.php and 1 other location - About 2 hrs to fix
        src/Message/StopRecurringRequest.php on lines 75..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function sendData($data)
    {
        $payload = $data;
        unset($payload['admin_username']);
        unset($payload['admin_password']);
        Severity: Major
        Found in src/Message/StopRecurringRequest.php and 1 other location - About 2 hrs to fix
        src/Message/RefundRequest.php on lines 96..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method getData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getData()
    {
        $this->validate('adminUsername', 'adminPassword', 'saleId', 'comment');

        $data = array();
        Severity: Minor
        Found in src/Message/RefundRequest.php - About 1 hr to fix

          Method getData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getData()
    {
        $this->validate('accountNumber', 'privateKey', 'token', 'amount', 'transactionId');

        $data = array();
          Severity: Minor
          Found in src/Message/TokenPurchaseRequest.php - About 1 hr to fix
            Severity
            Category
            Status
            Source
            Language