Sign upLogin

comfy/comfortable-mexican-sofa

View on GitHub
Star
test/integration/render_cms_test.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class RenderCmsIntergrationTest has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class RenderCmsIntergrationTest < ActionDispatch::IntegrationTest

  def setup
    super
    Rails.application.routes.draw do
Severity: Minor
Found in test/integration/render_cms_test.rb - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def test_implicit_cms_page
    page = comfy_cms_pages(:child)
    page.update(slug: "render-basic")
    get "/render-basic?type=page_implicit"
    assert_response :success
    Severity: Minor
    Found in test/integration/render_cms_test.rb and 2 other locations - About 25 mins to fix
    test/integration/render_cms_test.rb on lines 140..149
    test/integration/render_cms_test.rb on lines 152..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def test_explicit_cms_page
    page = comfy_cms_pages(:child)
    page.update(slug: "test-page")
    get "/render-page?type=page_explicit"
    assert_response :success
    Severity: Minor
    Found in test/integration/render_cms_test.rb and 2 other locations - About 25 mins to fix
    test/integration/render_cms_test.rb on lines 120..129
    test/integration/render_cms_test.rb on lines 152..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def test_explicit_cms_page_with_status
    page = comfy_cms_pages(:child)
    page.update(slug: "test-page")
    get "/render-page?type=page_explicit_with_status"
    assert_response :not_found
    Severity: Minor
    Found in test/integration/render_cms_test.rb and 2 other locations - About 25 mins to fix
    test/integration/render_cms_test.rb on lines 120..129
    test/integration/render_cms_test.rb on lines 140..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def test_cms_layout_with_action
    content = "{{cms:text content}} {{cms:text content_b}} {{cms:text content_c}}"
    comfy_cms_layouts(:default).update_columns(content: content)
    get "/render-layout?type=layout_with_action"
    assert_response :success
    Severity: Minor
    Found in test/integration/render_cms_test.rb and 1 other location - About 25 mins to fix
    test/integration/render_cms_test.rb on lines 219..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def test_cms_layout
    content = "{{cms:text content}} {{cms:text content_b}} {{cms:text content_c}}"
    comfy_cms_layouts(:default).update_columns(content: content)
    get "/render-layout?type=layout"
    assert_response :success
    Severity: Minor
    Found in test/integration/render_cms_test.rb and 1 other location - About 25 mins to fix
    test/integration/render_cms_test.rb on lines 239..247

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status