commitsto/commits.to

View on GitHub
test/lib/latepenalty.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  context('when the promise is a week late', () => {
    def('lateness', () => ({ weeks: 1 }))

    it('gives 90% credit', () => {
      expect($credit).to.eq(0.9)
Severity: Major
Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
test/lib/latepenalty.js on lines 14..20
test/lib/latepenalty.js on lines 22..28
test/lib/latepenalty.js on lines 30..36
test/lib/latepenalty.js on lines 46..52
test/lib/latepenalty.js on lines 54..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  context('when the promise is a day late', () => {
    def('lateness', () => ({ days: 1 }))

    it('gives 99% credit', () => {
      expect($credit).to.eq(0.99)
Severity: Major
Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
test/lib/latepenalty.js on lines 14..20
test/lib/latepenalty.js on lines 22..28
test/lib/latepenalty.js on lines 38..44
test/lib/latepenalty.js on lines 46..52
test/lib/latepenalty.js on lines 54..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  context('when the promise is a year late', () => {
    def('lateness', () => ({ years: 1 }))

    it('gives 10% credit', () => {
      expect($credit).to.eq(0.1)
Severity: Major
Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
test/lib/latepenalty.js on lines 14..20
test/lib/latepenalty.js on lines 22..28
test/lib/latepenalty.js on lines 30..36
test/lib/latepenalty.js on lines 38..44
test/lib/latepenalty.js on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  context('when the promise is a minute late', () => {
    def('lateness', () => ({ minutes: 1 }))

    it('gives 99.999% credit', () => {
      expect($credit).to.eq(0.99999)
Severity: Major
Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
test/lib/latepenalty.js on lines 22..28
test/lib/latepenalty.js on lines 30..36
test/lib/latepenalty.js on lines 38..44
test/lib/latepenalty.js on lines 46..52
test/lib/latepenalty.js on lines 54..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  context('when the promise is an hour late', () => {
    def('lateness', () => ({ hours: 1 }))

    it('gives 99.9% credit', () => {
      expect($credit).to.eq(0.999)
Severity: Major
Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
test/lib/latepenalty.js on lines 14..20
test/lib/latepenalty.js on lines 30..36
test/lib/latepenalty.js on lines 38..44
test/lib/latepenalty.js on lines 46..52
test/lib/latepenalty.js on lines 54..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  context('when the promise is a month late', () => {
    def('lateness', () => ({ months: 1 }))

    it('gives 50% credit', () => {
      expect($credit).to.eq(0.5)
Severity: Major
Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
test/lib/latepenalty.js on lines 14..20
test/lib/latepenalty.js on lines 22..28
test/lib/latepenalty.js on lines 30..36
test/lib/latepenalty.js on lines 38..44
test/lib/latepenalty.js on lines 54..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status