Sign upLogin

commitsto/commits.to

View on GitHub
Star

Showing 55 of 55 total issues

Function credit has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

export default function credit(t) {
  return t <= 0   ? 1 : // not late at all or early => full credit
         t < 60   ? hscale(hSecs, t, 0,    60,     1,     cSecs) :
         t < 3600 ? hscale(hMins, t, 60,   3600,   cSecs, cMins) :
         t < SID  ? hscale(hHrs,  t, 3600, SID,    cMins, cHrs)  :
Severity: Minor
Found in lib/latepenalty.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public render() {
    const { handleDelete, handleSubmit, validateFields } = this;
    const { promise: { user = {}, ...promise } = {} } = this.state;

    return (
Severity: Major
Found in client/src/views/edit.tsx - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                  <FormGroup>
                <label htmlFor='tdue'>Due Date</label>
                <Field component={DatePicker} name="tdue" />
                <ErrorMessage name="tdue" component="div" />
              </FormGroup>
    Severity: Major
    Found in client/src/views/edit.tsx and 2 other locations - About 1 hr to fix
    client/src/views/edit.tsx on lines 162..166
    client/src/views/edit.tsx on lines 174..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                  <FormGroup>
                <label htmlFor='tini'>Created Date</label>
                <Field component={DatePicker} name="tini" />
                <ErrorMessage name="tini" component="div" />
              </FormGroup>
    Severity: Major
    Found in client/src/views/edit.tsx and 2 other locations - About 1 hr to fix
    client/src/views/edit.tsx on lines 168..172
    client/src/views/edit.tsx on lines 174..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                  <FormGroup>
                <label htmlFor='tfin'>Finish Date</label>
                <Field component={DatePicker} name="tfin" />
                <ErrorMessage name="tfin" component="div" />
              </FormGroup>
    Severity: Major
    Found in client/src/views/edit.tsx and 2 other locations - About 1 hr to fix
    client/src/views/edit.tsx on lines 162..166
    client/src/views/edit.tsx on lines 168..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      context('when the promise is a day late', () => {
    def('lateness', () => ({ days: 1 }))

    it('gives 99% credit', () => {
      expect($credit).to.eq(0.99)
    Severity: Major
    Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
    test/lib/latepenalty.js on lines 14..20
    test/lib/latepenalty.js on lines 22..28
    test/lib/latepenalty.js on lines 38..44
    test/lib/latepenalty.js on lines 46..52
    test/lib/latepenalty.js on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      context('when the promise is a week late', () => {
    def('lateness', () => ({ weeks: 1 }))

    it('gives 90% credit', () => {
      expect($credit).to.eq(0.9)
    Severity: Major
    Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
    test/lib/latepenalty.js on lines 14..20
    test/lib/latepenalty.js on lines 22..28
    test/lib/latepenalty.js on lines 30..36
    test/lib/latepenalty.js on lines 46..52
    test/lib/latepenalty.js on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      context('when the promise is a month late', () => {
    def('lateness', () => ({ months: 1 }))

    it('gives 50% credit', () => {
      expect($credit).to.eq(0.5)
    Severity: Major
    Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
    test/lib/latepenalty.js on lines 14..20
    test/lib/latepenalty.js on lines 22..28
    test/lib/latepenalty.js on lines 30..36
    test/lib/latepenalty.js on lines 38..44
    test/lib/latepenalty.js on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      context('when the promise is an hour late', () => {
    def('lateness', () => ({ hours: 1 }))

    it('gives 99.9% credit', () => {
      expect($credit).to.eq(0.999)
    Severity: Major
    Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
    test/lib/latepenalty.js on lines 14..20
    test/lib/latepenalty.js on lines 30..36
    test/lib/latepenalty.js on lines 38..44
    test/lib/latepenalty.js on lines 46..52
    test/lib/latepenalty.js on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      context('when the promise is a minute late', () => {
    def('lateness', () => ({ minutes: 1 }))

    it('gives 99.999% credit', () => {
      expect($credit).to.eq(0.99999)
    Severity: Major
    Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
    test/lib/latepenalty.js on lines 22..28
    test/lib/latepenalty.js on lines 30..36
    test/lib/latepenalty.js on lines 38..44
    test/lib/latepenalty.js on lines 46..52
    test/lib/latepenalty.js on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      context('when the promise is a year late', () => {
    def('lateness', () => ({ years: 1 }))

    it('gives 10% credit', () => {
      expect($credit).to.eq(0.1)
    Severity: Major
    Found in test/lib/latepenalty.js and 5 other locations - About 1 hr to fix
    test/lib/latepenalty.js on lines 14..20
    test/lib/latepenalty.js on lines 22..28
    test/lib/latepenalty.js on lines 30..36
    test/lib/latepenalty.js on lines 38..44
    test/lib/latepenalty.js on lines 46..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      context('when the url ends in /by', () => {
    def('url', () => '/test/this/thing/by');

    it('rejects the /by', () => {
      expect($subject.valid).to.be.false;
    Severity: Major
    Found in test/lib/parse/url.js and 6 other locations - About 1 hr to fix
    test/lib/parse/url.js on lines 13..19
    test/lib/parse/url.js on lines 21..27
    test/lib/parse/url.js on lines 29..35
    test/lib/parse/url.js on lines 37..43
    test/lib/parse/url.js on lines 53..59
    test/lib/parse/url.js on lines 70..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      context('when the url repeats the username and domain', () => {
    def('url', () => '/tester.commits.to/test/the/things');

    it('rejects the url', () => {
      expect($subject.valid).to.be.false;
    Severity: Major
    Found in test/lib/parse/url.js and 6 other locations - About 1 hr to fix
    test/lib/parse/url.js on lines 13..19
    test/lib/parse/url.js on lines 21..27
    test/lib/parse/url.js on lines 29..35
    test/lib/parse/url.js on lines 37..43
    test/lib/parse/url.js on lines 45..51
    test/lib/parse/url.js on lines 70..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      context('when the url contains an apostrophe', () => {
    def('url', () => '/for-it\'s-test');

    it('rejects the apostrophe', () => {
      expect($subject.valid).to.be.false;
    Severity: Major
    Found in test/lib/parse/url.js and 6 other locations - About 1 hr to fix
    test/lib/parse/url.js on lines 13..19
    test/lib/parse/url.js on lines 29..35
    test/lib/parse/url.js on lines 37..43
    test/lib/parse/url.js on lines 45..51
    test/lib/parse/url.js on lines 53..59
    test/lib/parse/url.js on lines 70..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      context('when the url ends in abby', () => {
    def('url', () => '/test/this/thing/for/abby');

    it('does not reject the url', () => {
      expect($subject.valid).to.be.true;
    Severity: Major
    Found in test/lib/parse/url.js and 6 other locations - About 1 hr to fix
    test/lib/parse/url.js on lines 13..19
    test/lib/parse/url.js on lines 21..27
    test/lib/parse/url.js on lines 29..35
    test/lib/parse/url.js on lines 45..51
    test/lib/parse/url.js on lines 53..59
    test/lib/parse/url.js on lines 70..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      context('when the url contains a % sign', () => {
    def('url', () => '/space%20here');

    it('rejects the % sign', () => {
      expect($subject.valid).to.be.false;
    Severity: Major
    Found in test/lib/parse/url.js and 6 other locations - About 1 hr to fix
    test/lib/parse/url.js on lines 21..27
    test/lib/parse/url.js on lines 29..35
    test/lib/parse/url.js on lines 37..43
    test/lib/parse/url.js on lines 45..51
    test/lib/parse/url.js on lines 53..59
    test/lib/parse/url.js on lines 70..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      context('when the url has a file extension', () => {
    def('url', () => '/awekjad.txt');

    it('rejects the file extension', () => {
      expect($subject.valid).to.be.false;
    Severity: Major
    Found in test/lib/parse/url.js and 6 other locations - About 1 hr to fix
    test/lib/parse/url.js on lines 13..19
    test/lib/parse/url.js on lines 21..27
    test/lib/parse/url.js on lines 37..43
    test/lib/parse/url.js on lines 45..51
    test/lib/parse/url.js on lines 53..59
    test/lib/parse/url.js on lines 70..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      context('when the "?" is followed by a "/"', () => {
    def('url', () => 'go_running?/by/2:30pm');

    it('does not consider the url to have a querystring', () => {
      expect($subject.valid).to.be.true;
    Severity: Major
    Found in test/lib/parse/url.js and 6 other locations - About 1 hr to fix
    test/lib/parse/url.js on lines 13..19
    test/lib/parse/url.js on lines 21..27
    test/lib/parse/url.js on lines 29..35
    test/lib/parse/url.js on lines 37..43
    test/lib/parse/url.js on lines 45..51
    test/lib/parse/url.js on lines 53..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    interface IDayPickerProps {
  onChange: ({}) => void;
  raw: moment.Moment;
  showPicker?: boolean;
  toggleClick?: () => void;
    Severity: Major
    Found in client/src/components/form/picker/day.tsx and 1 other location - About 1 hr to fix
    client/src/components/form/picker/time.tsx on lines 24..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    interface ITimePickerProps {
  onChange: ({}) => void;
  raw: moment.Moment;
  showPicker?: boolean;
  toggleClick?: () => void;
    Severity: Major
    Found in client/src/components/form/picker/time.tsx and 1 other location - About 1 hr to fix
    client/src/components/form/picker/day.tsx on lines 23..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language