Sign upLogin

comparison-sorting/partition

View on GitHub
Star

Showing 11 of 11 total issues

Function hoare has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

const hoare = (compare, a, i, j) => {
    assert(i < j);

    const o = i;
    const x = a[o];
Severity: Minor
Found in src/partition/hoare.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function firstInversion has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

const firstInversion = (compare, array, left, right, pivots, pi, pj) => {
    let p = pivots[pi];
    let x = array[p];
    for (let k = left; k < p; ++k) {
        if (compare(array[k], x) > 0) return k;
Severity: Minor
Found in src/utils/firstInversion.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function yaroslavskiy has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const yaroslavskiy = (compare, a, i, j) => {
    assert(i < j);
    --j;

    // Choose outermost elements as pivots
Severity: Minor
Found in src/partition/yaroslavskiy.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            while (true) {
            ++i;

            if (i >= j) {
                a[o] = a[j];
    Severity: Major
    Found in src/partition/hoare.js and 1 other location - About 1 hr to fix
    src/partition/hoare.js on lines 17..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            while (true) {
            --j;

            if (i >= j) {
                a[o] = a[j];
    Severity: Major
    Found in src/partition/hoare.js and 1 other location - About 1 hr to fix
    src/partition/hoare.js on lines 31..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function yaroslavskiy has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    const yaroslavskiy = (compare, a, i, j) => {
    assert(i < j);
    --j;

    // Choose outermost elements as pivots
    Severity: Minor
    Found in src/partition/yaroslavskiy.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hoare has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const hoare = (compare, a, i, j) => {
    assert(i < j);

    const o = i;
    const x = a[o];
    Severity: Minor
    Found in src/partition/hoare.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if (compare(p, a[k]) > 0) {
                const t = a[k];
                a[k] = a[l];
                a[l] = t;
                ++l;
      Severity: Minor
      Found in src/partition/yaroslavskiy.js and 2 other locations - About 35 mins to fix
      src/partition/lomuto.js on lines 19..27
      src/partition/yaroslavskiy.js on lines 32..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (compare(p, a[k]) <= 0) {
            const t = a[k];
            a[k] = a[j];
            a[j] = t;
      Severity: Minor
      Found in src/partition/lomuto.js and 2 other locations - About 35 mins to fix
      src/partition/yaroslavskiy.js on lines 32..54
      src/partition/yaroslavskiy.js on lines 48..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (compare(p, a[k]) > 0) {
            const t = a[k];
            a[k] = a[l];
            a[l] = t;
      Severity: Minor
      Found in src/partition/yaroslavskiy.js and 2 other locations - About 35 mins to fix
      src/partition/lomuto.js on lines 19..27
      src/partition/yaroslavskiy.js on lines 48..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

          return right;
      Severity: Major
      Found in src/utils/firstInversion.js - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language