Sign upLogin

compodoc/ngd

View on GitHub
Star
src/modules/compiler/src/compiler.ts

Summary

Maintainability
F
3 days
Test Coverage

Function getSymbolDeps has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    private getSymbolDeps(props: NodeObject[], type: string): string[] {
        let deps = props.filter((node: NodeObject) => {
            return node.name.text === type;
        });
Severity: Minor
Found in src/modules/compiler/src/compiler.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File compiler.ts has 317 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as path from 'path';
import * as ts from 'typescript';
import { logger, getNewLineCharacter, compilerHost, d } from '@compodoc/ngd-core';
import { getNodeDecorators, nodeHasDecorator } from './utils';
Severity: Minor
Found in src/modules/compiler/src/compiler.ts - About 3 hrs to fix

    Function getSymbolDeps has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private getSymbolDeps(props: NodeObject[], type: string): string[] {
        let deps = props.filter((node: NodeObject) => {
            return node.name.text === type;
        });
    Severity: Major
    Found in src/modules/compiler/src/compiler.ts - About 3 hrs to fix

      Compiler has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export class Compiler {
    private files: string[];
    private program: ts.Program;
    private engine: any;
    private __cache: any = {};
      Severity: Minor
      Found in src/modules/compiler/src/compiler.ts - About 2 hrs to fix

        Function getSourceFileDecorators has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private getSourceFileDecorators(srcFile: ts.SourceFile, outputSymbols: Dependencies[]): void {
        ts.forEachChild(srcFile, (node: ts.Node) => {
            getNodeDecorators(node);
            let decorators = getNodeDecorators(node) || [];
            if (nodeHasDecorator(node)) {
        Severity: Minor
        Found in src/modules/compiler/src/compiler.ts - About 1 hr to fix

          Function visitNode has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          let visitNode = (visitedNode, index) => {
                    let name = this.getSymboleName(node);
                    let deps: Dependencies = <Dependencies>{};
                    let metadata = decorators[decorators.length - 1];
                    let props = this.findProps(visitedNode);
          Severity: Minor
          Found in src/modules/compiler/src/compiler.ts - About 1 hr to fix

            Function parseProviderConfiguration has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    let parseProviderConfiguration = (o: NodeObject): string => {
            // parse expressions such as:
            // { provide: APP_BASE_HREF, useValue: '/' },
            // or
            // { provide: 'Date', useFactory: (d1, d2) => new Date(), deps: ['d1', 'd2'] }
            Severity: Minor
            Found in src/modules/compiler/src/compiler.ts - About 1 hr to fix

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  private getComponentProviders(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'providers').map((name) => {
            return this.parseDeepIndentifier(name);
        });
    }
              Severity: Major
              Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
              src/modules/compiler/src/compiler.ts on lines 178..182
              src/modules/compiler/src/compiler.ts on lines 200..204
              src/modules/compiler/src/compiler.ts on lines 206..210
              src/modules/compiler/src/compiler.ts on lines 212..216

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  private getModuleBootstrap(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'bootstrap').map((name) => {
            return this.parseDeepIndentifier(name);
        });
    }
              Severity: Major
              Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
              src/modules/compiler/src/compiler.ts on lines 178..182
              src/modules/compiler/src/compiler.ts on lines 200..204
              src/modules/compiler/src/compiler.ts on lines 206..210
              src/modules/compiler/src/compiler.ts on lines 218..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  private getModuleImports(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'imports').map((name) => {
            return this.parseDeepIndentifier(name);
        });
    }
              Severity: Major
              Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
              src/modules/compiler/src/compiler.ts on lines 178..182
              src/modules/compiler/src/compiler.ts on lines 206..210
              src/modules/compiler/src/compiler.ts on lines 212..216
              src/modules/compiler/src/compiler.ts on lines 218..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  private getModuleExports(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'exports').map((name) => {
            return this.parseDeepIndentifier(name);
        });
    }
              Severity: Major
              Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
              src/modules/compiler/src/compiler.ts on lines 178..182
              src/modules/compiler/src/compiler.ts on lines 200..204
              src/modules/compiler/src/compiler.ts on lines 212..216
              src/modules/compiler/src/compiler.ts on lines 218..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  private getModuleProviders(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'providers').map((providerName) => {
            return this.parseDeepIndentifier(providerName);
        });
    }
              Severity: Major
              Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
              src/modules/compiler/src/compiler.ts on lines 200..204
              src/modules/compiler/src/compiler.ts on lines 206..210
              src/modules/compiler/src/compiler.ts on lines 212..216
              src/modules/compiler/src/compiler.ts on lines 218..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status