Sign upLogin

compozed/ops_manager_cli

View on GitHub
Star

Showing 12 of 12 total issues

Class Opsman has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Opsman < OpsManager::Api::Base
      def create_user
        body= "setup[decryption_passphrase]=#{password}&setup[decryption_passphrase_confirmation]=#{password}&setup[eula_accepted]=true&setup[identity_provider]=internal&setup[admin_user_name]=#{username}&setup[admin_password]=#{password}&setup[admin_password_confirmation]=#{password}"
        post("/api/v0/setup" , body: body)
      end
Severity: Minor
Found in lib/ops_manager/api/opsman.rb - About 3 hrs to fix

    Class ApplianceDeployment has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class OpsManager::ApplianceDeployment
  extend Forwardable
  attr_reader :config

  def_delegators :pivnet_api, :get_product_releases, :accept_product_release_eula,
    Severity: Minor
    Found in lib/ops_manager/appliance_deployment.rb - About 3 hrs to fix

      Method get has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def get(endpoint, opts = {})
        uri = uri_for(endpoint)
        http = http_for(uri)
        request = Net::HTTP::Get.new(uri.request_uri)
      Severity: Minor
      Found in lib/ops_manager/api/base.rb - About 1 hr to fix

        Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def run
    OpsManager.set_conf(:target, config[:ip])
    OpsManager.set_conf(:username, config[:username])
    OpsManager.set_conf(:password, config[:password])
    OpsManager.set_conf(:pivnet_token, config[:pivnet_token])
        Severity: Minor
        Found in lib/ops_manager/appliance_deployment.rb - About 1 hr to fix

          Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
    OpsManager.set_conf(:target, config[:ip])
    OpsManager.set_conf(:username, config[:username])
    OpsManager.set_conf(:password, config[:password])
    OpsManager.set_conf(:pivnet_token, config[:pivnet_token])
          Severity: Minor
          Found in lib/ops_manager/appliance_deployment.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method import_stemcell has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def import_stemcell(filepath, products = "all")
        return unless filepath
        tar = UploadIO.new(filepath, 'multipart/form-data')
        print_green "====> Uploading stemcell: #{filepath} ..."
          Severity: Minor
          Found in lib/ops_manager/api/opsman.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method expand_path_for! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def expand_path_for!(*attrs)
        attrs.each do |attr|
          path = self[attr] 
          next if path.nil?
          self[attr] = if path =~ %r{^file://}
          Severity: Minor
          Found in lib/ops_manager/config/base.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  res = http.request(request).tap do |res|
          logger.info("performing post to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("post response body #{res.body}")
          Severity: Minor
          Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
          lib/ops_manager/api/base.rb on lines 47..49
          lib/ops_manager/api/base.rb on lines 100..102
          lib/ops_manager/api/base.rb on lines 120..122
          lib/ops_manager/api/base.rb on lines 138..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  http.request(request).tap do |res|
          logger.info("performing put to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("put response body #{res.body}")
          Severity: Minor
          Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
          lib/ops_manager/api/base.rb on lines 47..49
          lib/ops_manager/api/base.rb on lines 68..70
          lib/ops_manager/api/base.rb on lines 120..122
          lib/ops_manager/api/base.rb on lines 138..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                    http.request(request).tap do |res|
            logger.info("performing get to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
            logger.info("get response body #{res.body}")
          Severity: Minor
          Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
          lib/ops_manager/api/base.rb on lines 68..70
          lib/ops_manager/api/base.rb on lines 100..102
          lib/ops_manager/api/base.rb on lines 120..122
          lib/ops_manager/api/base.rb on lines 138..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  http.request(request).tap do |res|
          logger.info("performing multipart_post to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("post response body #{res.body}")
          Severity: Minor
          Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
          lib/ops_manager/api/base.rb on lines 47..49
          lib/ops_manager/api/base.rb on lines 68..70
          lib/ops_manager/api/base.rb on lines 100..102
          lib/ops_manager/api/base.rb on lines 138..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  http.request(request).tap do |res|
          logger.info("performing delete to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("post response body #{res.body}")
          Severity: Minor
          Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
          lib/ops_manager/api/base.rb on lines 47..49
          lib/ops_manager/api/base.rb on lines 68..70
          lib/ops_manager/api/base.rb on lines 100..102
          lib/ops_manager/api/base.rb on lines 120..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language