Sign upLogin

compozed/ops_manager_cli

View on GitHub
Star

Showing 5 of 12 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        http.request(request).tap do |res|
          logger.info("performing delete to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("post response body #{res.body}")
Severity: Minor
Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
lib/ops_manager/api/base.rb on lines 47..49
lib/ops_manager/api/base.rb on lines 68..70
lib/ops_manager/api/base.rb on lines 100..102
lib/ops_manager/api/base.rb on lines 120..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          http.request(request).tap do |res|
            logger.info("performing get to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
            logger.info("get response body #{res.body}")
Severity: Minor
Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
lib/ops_manager/api/base.rb on lines 68..70
lib/ops_manager/api/base.rb on lines 100..102
lib/ops_manager/api/base.rb on lines 120..122
lib/ops_manager/api/base.rb on lines 138..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        http.request(request).tap do |res|
          logger.info("performing put to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("put response body #{res.body}")
Severity: Minor
Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
lib/ops_manager/api/base.rb on lines 47..49
lib/ops_manager/api/base.rb on lines 68..70
lib/ops_manager/api/base.rb on lines 120..122
lib/ops_manager/api/base.rb on lines 138..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        http.request(request).tap do |res|
          logger.info("performing multipart_post to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("post response body #{res.body}")
Severity: Minor
Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
lib/ops_manager/api/base.rb on lines 47..49
lib/ops_manager/api/base.rb on lines 68..70
lib/ops_manager/api/base.rb on lines 100..102
lib/ops_manager/api/base.rb on lines 138..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        res = http.request(request).tap do |res|
          logger.info("performing post to #{uri} with opts: #{opts.inspect}  res.code: #{res.code}")
          logger.info("post response body #{res.body}")
Severity: Minor
Found in lib/ops_manager/api/base.rb and 4 other locations - About 15 mins to fix
lib/ops_manager/api/base.rb on lines 47..49
lib/ops_manager/api/base.rb on lines 100..102
lib/ops_manager/api/base.rb on lines 120..122
lib/ops_manager/api/base.rb on lines 138..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language