conan-io/conan

View on GitHub
conan/tools/_compilers.py

Summary

Maintainability
F
2 wks
Test Coverage

Function architecture_flag has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
Open

def architecture_flag(settings):
    """
    returns flags specific to the target architecture and compiler
    """
    compiler = settings.get_safe("compiler")
Severity: Minor
Found in conan/tools/_compilers.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return {"e2k-v2": "-march=elbrus-v2",
Severity: Major
Found in conan/tools/_compilers.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return ""
    Severity: Major
    Found in conan/tools/_compilers.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return ""
      Severity: Major
      Found in conan/tools/_compilers.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return '-m32'
        Severity: Major
        Found in conan/tools/_compilers.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return '-maix64'
          Severity: Major
          Found in conan/tools/_compilers.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return "/Qm64" if str(compiler_base) == "Visual Studio" else "-m64"
            Severity: Major
            Found in conan/tools/_compilers.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return "/Qm32" if the_os == "Windows" else "-m32"
              Severity: Major
              Found in conan/tools/_compilers.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return "/Qm32" if str(compiler_base) == "Visual Studio" else "-m32"
                Severity: Major
                Found in conan/tools/_compilers.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return "/Qm64" if the_os == "Windows" else "-m64"
                  Severity: Major
                  Found in conan/tools/_compilers.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return '-m31'
                    Severity: Major
                    Found in conan/tools/_compilers.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return '-maix32'
                      Severity: Major
                      Found in conan/tools/_compilers.py - About 30 mins to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        def _cppstd_clang(clang_version, cppstd):
                            """
                            Inspired in:
                            https://github.com/Kitware/CMake/blob/
                            1fe2dc5ef2a1f262b125a2ba6a85f624ce150dd2/Modules/Compiler/Clang-CXX.cmake
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 2 days to fix
                        conans/client/build/cppstd_flags.py on lines 182..234

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 308.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        def _cppstd_gcc(gcc_version, cppstd):
                            """https://github.com/Kitware/CMake/blob/master/Modules/Compiler/GNU-CXX.cmake"""
                            # https://gcc.gnu.org/projects/cxx-status.html
                            v98 = vgnu98 = v11 = vgnu11 = v14 = vgnu14 = v17 = vgnu17 = v20 = vgnu20 = v23 = vgnu23 = None
                        
                        
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 2 days to fix
                        conans/client/build/cppstd_flags.py on lines 237..282

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 296.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        def _cppstd_apple_clang(clang_version, cppstd):
                            """
                            Inspired in:
                            https://github.com/Kitware/CMake/blob/master/Modules/Compiler/AppleClang-CXX.cmake
                            """
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 2 days to fix
                        conans/client/build/cppstd_flags.py on lines 139..179

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 228.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if str(compiler) in ['gcc', 'apple-clang', 'clang', 'sun-cc']:
                                if str(the_os) == 'Macos' and str(subsystem) == 'catalyst':
                                    # FIXME: This might be conflicting with Autotools --target cli arg
                                    apple_arch = to_apple_arch(arch)
                                    if apple_arch:
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 1 day to fix
                        conans/client/build/compiler_flags.py on lines 50..65

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 171.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        def _cppstd_intel_common(intel_version, cppstd, vgnu98, vgnu0x):
                            # https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-std-qstd
                            # https://software.intel.com/en-us/articles/intel-cpp-compiler-release-notes
                            # NOTE: there are only gnu++98 and gnu++0x, and only for Linux/macOS
                            v98 = v11 = v14 = v17 = v20 = None
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 1 day to fix
                        conans/client/build/cppstd_flags.py on lines 285..309

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 162.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        def _cppstd_mcst_lcc(mcst_lcc_version, cppstd):
                            v11 = vgnu11 = v14 = vgnu14 = v17 = vgnu17 = v20 = vgnu20 = None
                        
                            if Version(mcst_lcc_version) >= "1.21":
                                v11 = "c++11"
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 1 day to fix
                        conans/client/build/cppstd_flags.py on lines 322..345

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 153.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        def _cppstd_visualstudio(visual_version, cppstd):
                            # https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version
                            v14 = None
                            v17 = None
                            v20 = None
                        Severity: Major
                        Found in conan/tools/_compilers.py and 3 other locations - About 1 day to fix
                        conan/tools/_compilers.py on lines 197..215
                        conans/client/build/cppstd_flags.py on lines 97..115
                        conans/client/build/cppstd_flags.py on lines 118..136

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 140.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        def _cppstd_msvc(visual_version, cppstd):
                            # https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version
                            v14 = None
                            v17 = None
                            v20 = None
                        Severity: Major
                        Found in conan/tools/_compilers.py and 3 other locations - About 1 day to fix
                        conan/tools/_compilers.py on lines 176..194
                        conans/client/build/cppstd_flags.py on lines 97..115
                        conans/client/build/cppstd_flags.py on lines 118..136

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 140.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if str(compiler) in ['Visual Studio', 'msvc']:
                                if vs_toolset and "clang" in str(vs_toolset):
                                    flags = {"Debug": ["-gline-tables-only", "-fno-inline", "-O0"],
                                             "Release": ["-O2"],
                                             "RelWithDebInfo": ["-gline-tables-only", "-O2", "-fno-inline"],
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 1 day to fix
                        conans/client/build/compiler_flags.py on lines 142..179

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 123.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            elif str(compiler) == "intel":
                                # https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-m32-m64-qm32-qm64
                                if str(arch) == "x86":
                                    return "/Qm32" if str(compiler_base) == "Visual Studio" else "-m32"
                                elif str(arch) == "x86_64":
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 3 hrs to fix
                        conans/client/build/compiler_flags.py on lines 66..71

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            elif str(compiler) == "intel-cc":
                                # https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-m32-m64-qm32-qm64
                                if str(arch) == "x86":
                                    return "/Qm32" if the_os == "Windows" else "-m32"
                                elif str(arch) == "x86_64":
                        Severity: Major
                        Found in conan/tools/_compilers.py and 1 other location - About 1 hr to fix
                        conans/client/build/compiler_flags.py on lines 66..78

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 42.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        def _cppstd_intel_gcc(intel_version, cppstd):
                            flag = _cppstd_intel_common(intel_version, cppstd, "gnu++98", "gnu++0x")
                            return "-std=%s" % flag if flag else None
                        Severity: Minor
                        Found in conan/tools/_compilers.py and 1 other location - About 40 mins to fix
                        conans/client/build/cppstd_flags.py on lines 312..314

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 34.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        def _cppstd_intel_visualstudio(intel_version, cppstd):
                            flag = _cppstd_intel_common(intel_version, cppstd, None, None)
                            return "/Qstd=%s" % flag if flag else None
                        Severity: Minor
                        Found in conan/tools/_compilers.py and 1 other location - About 40 mins to fix
                        conans/client/build/cppstd_flags.py on lines 317..319

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 34.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status