conan-io/conan

View on GitHub
conans/client/graph/graph_manager.py

Summary

Maintainability
C
1 day
Test Coverage

Function _recurse_build_requires has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
Open

    def _recurse_build_requires(self, graph, builder, check_updates,
                                update, build_mode, remotes, profile_build_requires, recorder,
                                profile_host, profile_build, graph_lock, apply_build_requires=True,
                                nodes_subset=None, root=None):
        """
Severity: Minor
Found in conans/client/graph/graph_manager.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _recurse_build_requires has 15 arguments (exceeds 10 allowed). Consider refactoring.
Open

    def _recurse_build_requires(self, graph, builder, check_updates,
Severity: Major
Found in conans/client/graph/graph_manager.py - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if ctxt == CONTEXT_BUILD:
                                br_build.append((it, ctxt))
                            else:
                                br_host.append((it, ctxt))
                        if br_build:
    Severity: Major
    Found in conans/client/graph/graph_manager.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if br_key in package_build_requires:  # Override defined
                                  # this is a way to have only one package Name for all versions
                                  # (no conflicts)
                                  # but the dict key is not used at all
                                  package_build_requires[br_key] = build_require
      Severity: Major
      Found in conans/client/graph/graph_manager.py - About 45 mins to fix

        Function load_graph has 12 arguments (exceeds 10 allowed). Consider refactoring.
        Open

            def load_graph(self, reference, create_reference, graph_info, build_mode, check_updates, update,
        Severity: Major
        Found in conans/client/graph/graph_manager.py - About 45 mins to fix

          Function _load_graph has 11 arguments (exceeds 10 allowed). Consider refactoring.
          Open

              def _load_graph(self, root_node, check_updates, update, build_mode, remotes,
          Severity: Major
          Found in conans/client/graph/graph_manager.py - About 35 mins to fix

            Line too long (103 > 100 characters)
            Open

                    if "explicit" not in test_type:  # 2.0 mode, not automatically add the require, always explicit
            Severity: Minor
            Found in conans/client/graph/graph_manager.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
            lines; plus, limiting windows to 80 characters makes it possible to
            have several windows side-by-side.  The default wrapping on such
            devices looks ugly.  Therefore, please limit all lines to a maximum
            of 79 characters. For flowing long blocks of text (docstrings or
            comments), limiting the length to 72 characters is recommended.
            
            Reports error E501.

            Line too long (101 > 100 characters)
            Open

                        package_build_requires = self._get_recipe_build_requires(node.conanfile, default_context)
            Severity: Minor
            Found in conans/client/graph/graph_manager.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
            lines; plus, limiting windows to 80 characters makes it possible to
            have several windows side-by-side.  The default wrapping on such
            devices looks ugly.  Therefore, please limit all lines to a maximum
            of 79 characters. For flowing long blocks of text (docstrings or
            comments), limiting the length to 72 characters is recommended.
            
            Reports error E501.

            Line too long (101 > 100 characters)
            Open

                        root_node = Node(ref, conanfile, context=CONTEXT_HOST, recipe=RECIPE_CONSUMER, path=path)
            Severity: Minor
            Found in conans/client/graph/graph_manager.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
            lines; plus, limiting windows to 80 characters makes it possible to
            have several windows side-by-side.  The default wrapping on such
            devices looks ugly.  Therefore, please limit all lines to a maximum
            of 79 characters. For flowing long blocks of text (docstrings or
            comments), limiting the length to 72 characters is recommended.
            
            Reports error E501.

            Continuation line over-indented for visual indent
            Open

                                                            require_overrides)
            Severity: Minor
            Found in conans/client/graph/graph_manager.py by pep8

            Continuation lines indentation.

            Continuation lines should align wrapped elements either vertically
            using Python's implicit line joining inside parentheses, brackets
            and braces, or using a hanging indent.
            
            When using a hanging indent these considerations should be applied:
            - there should be no arguments on the first line, and
            - further indentation should be used to clearly distinguish itself
              as a continuation line.
            
            Okay: a = (\n)
            E123: a = (\n    )
            
            Okay: a = (\n    42)
            E121: a = (\n   42)
            E122: a = (\n42)
            E123: a = (\n    42\n    )
            E124: a = (24,\n     42\n)
            E125: if (\n    b):\n    pass
            E126: a = (\n        42)
            E127: a = (24,\n      42)
            E128: a = (24,\n    42)
            E129: if (a or\n    b):\n    pass
            E131: a = (\n    42\n 24)

            There are no issues that match your filters.

            Category
            Status