conan-io/conan

View on GitHub
conans/client/subsystems.py

Summary

Maintainability
F
3 days
Test Coverage

Avoid too many return statements within this function.
Open

            return '/dev/fs' + path[0] + path[1:].capitalize()
Severity: Major
Found in conans/client/subsystems.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return None
    Severity: Major
    Found in conans/client/subsystems.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return path if subsystem == WSL else path.lower()
      Severity: Major
      Found in conans/client/subsystems.py - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        def get_cased_path(name):
            if platform.system() != "Windows":
                return name
            if not os.path.isabs(name):
                name = os.path.abspath(name)
        Severity: Major
        Found in conans/client/subsystems.py and 1 other location - About 1 day to fix
        conans/client/tools/win.py on lines 577..601

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 205.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if append_prefix:
                if subsystem in (MSYS, MSYS2):
                    return path.lower()
                elif subsystem == CYGWIN:
                    return '/cygdrive' + path.lower()
        Severity: Major
        Found in conans/client/subsystems.py and 1 other location - About 1 day to fix
        conans/client/tools/win.py on lines 631..642

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 163.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        def _escape_windows_cmd(command):
            """ To use in a regular windows cmd.exe
                1. Adds escapes so the argument can be unpacked by CommandLineToArgvW()
                2. Adds escapes for cmd.exe so the argument survives cmd.exe's substitutions.
        
        
        Severity: Major
        Found in conans/client/subsystems.py and 1 other location - About 2 hrs to fix
        conans/client/tools/win.py on lines 566..574

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Line too long (114 > 100 characters)
        Open

                                            tools.microsoft.bash:path=None) NO ERROR mode for not specifying it? =CURRENT?
        Severity: Minor
        Found in conans/client/subsystems.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
        lines; plus, limiting windows to 80 characters makes it possible to
        have several windows side-by-side.  The default wrapping on such
        devices looks ugly.  Therefore, please limit all lines to a maximum
        of 79 characters. For flowing long blocks of text (docstrings or
        comments), limiting the length to 72 characters is recommended.
        
        Reports error E501.

        There are no issues that match your filters.

        Category
        Status