Sign upLogin

concord-consortium/lara

View on GitHub
Star
lib/concord/auth_portal.rb

Summary

Maintainability
B
6 hrs
Test Coverage
B
84%

Method new_strategy has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.new_strategy(name,url,client_id,secret)
      site = url
      auth_url = "#{url}#{AuthorizeUrl}"
      access_token_url = "#{url}#{AccessTokenUrl}"
      class_name = "cc_portal_#{name.downcase}".classify
Severity: Major
Found in lib/concord/auth_portal.rb - About 3 hrs to fix

    Class AuthPortal has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class AuthPortal

    ExistingPortals   = {}
    AuthorizeUrl      = "/auth/concord_id/authorize"
    AccessTokenUrl    = "/auth/concord_id/access_token"
    Severity: Minor
    Found in lib/concord/auth_portal.rb - About 2 hrs to fix

      Method portal_for_url has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.portal_for_url(url)
      # URI.parse(url).host returns nil when scheme is not provided.
      host = URI(url).host || URI("http://#{url}").host
      port = URI(url).port || 80
      return nil unless host
      Severity: Minor
      Found in lib/concord/auth_portal.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status