Sign upLogin

concord-consortium/rigse

View on GitHub
Star
admin-panel/graphql-backend/src/resolvers/AdminProjectUserResolver.ts

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Mutation(() => AdminProjectUser)
  async updateAdminProjectUser(
      @Args() args: UpdateAdminProjectUserArgs) {
      const {id, ...params} = args;
      // NOTE: the relations: ["project"] is added so the returned projectUser
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/AdminProjectUserResolver.ts and 1 other location - About 5 hrs to fix
admin-panel/graphql-backend/src/resolvers/PortalStudentPermissionFormResolver.ts on lines 104..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Query(() => [AdminProjectUser])
  allAdminProjectUsers(
    @Args() {filter, page, perPage, sortField, sortOrder}:AdminProjectUserQueryArgs) {
    // FIXME: Including the project relation here is kind of inefficient
    // hopefully typeorm uses n+1 optimization, but it still means extra objects
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/AdminProjectUserResolver.ts and 1 other location - About 5 hrs to fix
admin-panel/graphql-backend/src/resolvers/PortalStudentPermissionFormResolver.ts on lines 61..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Mutation(() => AdminProjectUser)
  async createAdminProjectUser(
    @Args() args: CreateAdminProjectUserArgs) {
      const createdAt = new Date()
      const updatedAt = new Date()
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/AdminProjectUserResolver.ts and 1 other location - About 3 hrs to fix
admin-panel/graphql-backend/src/resolvers/PortalStudentPermissionFormResolver.ts on lines 123..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Query(() => listMeta)
  _allAdminProjectUsersMeta(
    @Args() {filter, page, perPage, sortField, sortOrder}:AdminProjectUserQueryArgs) {
      const where = filter
      const count = AdminProjectUser.count({where})
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/AdminProjectUserResolver.ts and 1 other location - About 3 hrs to fix
admin-panel/graphql-backend/src/resolvers/PortalStudentPermissionFormResolver.ts on lines 83..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Mutation(() => AdminProjectUser)
  async deleteAdminProjectUser(@Arg("id") id: string) {
    const projectUser = await AdminProjectUser.findOne({ where: { id } });
    if (!projectUser) throw new Error("AdminProjectUser not found!");
    await projectUser.remove();
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/AdminProjectUserResolver.ts and 1 other location - About 2 hrs to fix
admin-panel/graphql-backend/src/resolvers/PortalStudentPermissionFormResolver.ts on lines 135..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

@ArgsType()
class PageSortQueryArgs {
  @Field(type => Int)
  page: number;
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/AdminProjectUserResolver.ts and 1 other location - About 2 hrs to fix
admin-panel/graphql-backend/src/resolvers/PortalStudentPermissionFormResolver.ts on lines 28..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status