Sign upLogin

concord-consortium/rigse

View on GitHub
Star
admin-panel/graphql-backend/src/resolvers/PortalStudentResolver.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Authorized()
  @Mutation(() => PortalStudent)
  async deletePortalStudent(@Arg("id") id: string) {
    const portalStudent = await PortalStudent.findOne({
      where: { id }
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/PortalStudentResolver.ts and 1 other location - About 2 hrs to fix
admin-panel/graphql-backend/src/resolvers/UserResolver.ts on lines 82..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  @Authorized()
  @Query(() => listMeta)
  async _allPortalStudentsMeta(@Args() searchParams:PortalStudentPaginationAndFilter){
    const count = await fuzzyCount<PortalStudent>(PortalStudent, 'PortalStudent', searchParams);
    return {count}
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/PortalStudentResolver.ts and 3 other locations - About 1 hr to fix
admin-panel/graphql-backend/src/resolvers/AdminProjectResolver.ts on lines 60..65
admin-panel/graphql-backend/src/resolvers/PortalPermissionFormResolver.ts on lines 51..56
admin-panel/graphql-backend/src/resolvers/UserResolver.ts on lines 69..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  @Authorized()
  @Query(() => PortalStudent)
  PortalStudent(@Arg("id") id: string) {
    return PortalStudent.findOne({ where: { id }, relations: ["user"]});
  }
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/PortalStudentResolver.ts and 2 other locations - About 1 hr to fix
admin-panel/graphql-backend/src/resolvers/PortalPermissionFormResolver.ts on lines 58..62
admin-panel/graphql-backend/src/resolvers/UserResolver.ts on lines 76..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  @Authorized()
  @Query(() => [PortalStudent])
  async allPortalStudents(@Args() searchParams:PortalStudentPaginationAndFilter) {
    return await fuzzyFetch<PortalStudent>(PortalStudent, 'PortalStudent', searchParams);
  }
Severity: Major
Found in admin-panel/graphql-backend/src/resolvers/PortalStudentResolver.ts and 3 other locations - About 1 hr to fix
admin-panel/graphql-backend/src/resolvers/AdminProjectResolver.ts on lines 54..58
admin-panel/graphql-backend/src/resolvers/PortalPermissionFormResolver.ts on lines 45..49
admin-panel/graphql-backend/src/resolvers/UserResolver.ts on lines 63..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status