Sign upLogin

concord-consortium/rigse

View on GitHub
Star

Showing 2,136 of 2,138 total issues

Function createBMP has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    var createBMP = function(oData) {
        var strHeader = '',
            iWidth = oData.width,
            iHeight = oData.height;
Severity: Minor
Found in rails/app/assets/javascripts/canvas2image.js - About 1 hr to fix

    Function Shrink has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Effect.Shrink = function(element) {
  element = $(element);
  var options = Object.extend({
    direction: 'center',
    moveTransition: Effect.Transitions.sinoidal,
    Severity: Minor
    Found in rails/app/assets/javascripts/effects.js - About 1 hr to fix

      Method render_info has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def render_info(clazz, anonymize)
    state = nil
    if school = clazz.school
      state = school.state
    end
      Severity: Minor
      Found in rails/app/controllers/api/v1/classes_controller.rb - About 1 hr to fix

        Function renderAnonymous has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          renderAnonymous (showEnewsSubscription: any) {
    return (
      <div>
        <dl>
          <dt>Username</dt>
        Severity: Minor
        Found in rails/react-components/src/library/components/signup/teacher_form.tsx - About 1 hr to fix

          Function render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render () {
    const anonymous = this.props.anonymous;

    const providerComponents = [];
    if (enableAuthProviders && this.props.oauthProviders) {
          Severity: Minor
          Found in rails/react-components/src/library/components/signup/basic_data_form.tsx - About 1 hr to fix

            Function setRequestHeaders has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              setRequestHeaders: function() {
    var headers = {
      'X-Requested-With': 'XMLHttpRequest',
      'X-Prototype-Version': Prototype.Version,
      'Accept': 'text/javascript, text/html, application/xml, text/xml, */*'
            Severity: Minor
            Found in rails/app/assets/javascripts/prototype.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function request has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              request: function(url) {
    this.url = url;
    this.method = this.options.method;
    var params = Object.isString(this.options.parameters) ?
      this.options.parameters :
            Severity: Minor
            Found in rails/app/assets/javascripts/prototype.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function dealWithDeprecatedOptions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

            Ajax.InPlaceEditor.prototype.initialize.dealWithDeprecatedOptions = function(options) {
  if (!options) return;
  function fallback(name, expr) {
    if (name in options || expr === undefined) return;
    options[name] = expr;
            Severity: Minor
            Found in rails/app/assets/javascripts/controls.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function onHover has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              onHover: function(element, dropon, overlap) {
    if(Element.isParent(dropon, element)) return;

    if(overlap > .33 && overlap < .66 && Sortable.options(dropon).tree) {
      return;
            Severity: Minor
            Found in rails/app/assets/javascripts/dragdrop.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function setActiveTab has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                setActiveTab: function(link){
        if(!link && typeof(link) == 'undefined')
            return;
        if(typeof(link) == 'string'){
            this.setActiveTab(this.links.find(function(_link){
            Severity: Minor
            Found in rails/app/assets/javascripts/livepipe/tabs.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function draw has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              draw: function(point) {
    var pos = this.element.cumulativeOffset();
    if(this.options.ghosting) {
      var r   = Position.realOffset(this.element);
      pos[0] += r[0] - Position.deltaX; pos[1] += r[1] - Position.deltaY;
            Severity: Minor
            Found in rails/app/assets/javascripts/dragdrop.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method index has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              def index
    authorize Portal::Offering, :api_index?
    # policy_scope will limit offerings to ones available to given user.
    # All the other filtering will filter this initial set of offerings.
    offerings = policy_scope(Portal::Offering).includes(API::V1::Offering::INCLUDES_DEF)
            Severity: Minor
            Found in rails/app/controllers/api/v1/offerings_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              def create
    teacher_registration = API::V1::TeacherRegistration.new(teacher_registration_strong_params(params))

    # This was added to allow for registering after logging in the first time with SSO
    # But it also occurs if a user is able to access the registration form while being
            Severity: Minor
            Found in rails/app/controllers/api/v1/teachers_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method update has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              def update
    cancel = params[:commit] == "Cancel"
    @interactive = Interactive.find(params[:id])
    authorize @interactive
            Severity: Minor
            Found in rails/app/controllers/interactives_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method add_default_user has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.add_default_user(user_info)

    default_password = APP_CONFIG[:password_for_default_users]
    user = nil
    user_by_email = nil
            Severity: Minor
            Found in rails/lib/mock_data/create_default_data.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method not_authorized_error_message has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              def not_authorized_error_message(options={})
    resource_type = options[:resource_type] || ''
    resource_name = options[:resource_name] || ''
    additional_info = options[:additional_info] || ''
            Severity: Minor
            Found in rails/app/controllers/application_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method sitemap has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              def sitemap

    builder = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|

        xml.urlset('xmlns' => 'http://www.sitemaps.org/schemas/sitemap/0.9') {
            Severity: Minor
            Found in rails/app/controllers/robots_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                jQuery.post("/api/v1/users/sign_in", data).done(function (response) {
      if (response.redirect_path) {
        window.location = response.redirect_path;
      } else {
        window.location.reload();
            Severity: Major
            Found in rails/react-components/src/library/components/signup/login_modal.tsx and 1 other location - About 1 hr to fix
            rails/react-components/src/library/components/signup/student_registration_complete.tsx on lines 24..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                jQuery.post("/api/v1/users/sign_in", data).done(function (response) {
      if (response.redirect_path) {
        window.location = response.redirect_path;
      } else {
        window.location.reload();
            Severity: Major
            Found in rails/react-components/src/library/components/signup/student_registration_complete.tsx and 1 other location - About 1 hr to fix
            rails/react-components/src/library/components/signup/login_modal.tsx on lines 25..44

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getGradientSvg has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                getGradientSvg: function( info, bgWidth, bgHeight ) {
        var el = this.targetElement,
            stopsInfo = info.stops,
            stopCount = stopsInfo.length,
            metrics = PIE.GradientUtil.getGradientMetrics( el, bgWidth, bgHeight, info ),
            Severity: Minor
            Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language