Sign upLogin

concord-consortium/rigse

View on GitHub
Star

Showing 2,136 of 2,138 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <a className={css.resourceSharingFacebook} href={facebookLink} target="_blank" onClick={this.handleSocialMediaShare} rel="noreferrer">Facebook</a>
Severity: Major
Found in rails/react-components/src/library/components/browse-page/browse-page.tsx and 2 other locations - About 50 mins to fix
rails/react-components/src/library/components/browse-page/browse-page.tsx on lines 178..178
rails/react-components/src/library/components/browse-page/browse-page.tsx on lines 179..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

@Index("index_portal_countries_on_iso_id", ["isoId"], {})
@Index("index_portal_countries_on_name", ["name"], {})
@Index("index_portal_countries_on_two_letter", ["twoLetter"], {})
@Entity("portal_countries", { schema: "portal_development" })
export class PortalCountries {
Severity: Major
Found in admin-panel/graphql-backend/src/entities/unused/PortalCountries.ts and 5 other locations - About 50 mins to fix
admin-panel/graphql-backend/src/entities/unused/AdminCohortItems.ts on lines 3..19
admin-panel/graphql-backend/src/entities/unused/DataserviceBlobs.ts on lines 3..37
admin-panel/graphql-backend/src/entities/unused/PortalCourses.ts on lines 3..34
admin-panel/graphql-backend/src/entities/unused/PortalNces06Districts.ts on lines 3..271
admin-panel/graphql-backend/src/entities/unused/PortalOfferings.ts on lines 3..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

@Index("index_admin_cohort_items_on_item_id", ["itemId"], {})
@Index("index_admin_cohort_items_on_item_type", ["itemType"], {})
@Index("index_admin_cohort_items_on_admin_cohort_id", ["adminCohortId"], {})
@Entity("admin_cohort_items", { schema: "portal_development" })
export class AdminCohortItems {
Severity: Major
Found in admin-panel/graphql-backend/src/entities/unused/AdminCohortItems.ts and 5 other locations - About 50 mins to fix
admin-panel/graphql-backend/src/entities/unused/DataserviceBlobs.ts on lines 3..37
admin-panel/graphql-backend/src/entities/unused/PortalCountries.ts on lines 3..37
admin-panel/graphql-backend/src/entities/unused/PortalCourses.ts on lines 3..34
admin-panel/graphql-backend/src/entities/unused/PortalNces06Districts.ts on lines 3..271
admin-panel/graphql-backend/src/entities/unused/PortalOfferings.ts on lines 3..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <a className={css.resourceSharingEmail} href={emailLink} target="_blank" onClick={this.handleSocialMediaShare} rel="noreferrer">Email</a>
Severity: Major
Found in rails/react-components/src/library/components/browse-page/browse-page.tsx and 2 other locations - About 50 mins to fix
rails/react-components/src/library/components/browse-page/browse-page.tsx on lines 177..177
rails/react-components/src/library/components/browse-page/browse-page.tsx on lines 178..178

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <a className={css.resourceSharingTwitter} href={twitterLink} target="_blank" onClick={this.handleSocialMediaShare} rel="noreferrer">Twitter</a>
Severity: Major
Found in rails/react-components/src/library/components/browse-page/browse-page.tsx and 2 other locations - About 50 mins to fix
rails/react-components/src/library/components/browse-page/browse-page.tsx on lines 177..177
rails/react-components/src/library/components/browse-page/browse-page.tsx on lines 179..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              { student.can_reset_password ? <span className={css.link} role="link" onClick={this.handleChangePassword}>Change Password</span> : undefined }
Severity: Minor
Found in rails/react-components/src/library/components/portal-classes/student-roster-row.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/portal-classes/student-roster-row.tsx on lines 33..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const title = (str: any) => (str.charAt(0).toUpperCase() + str.slice(1)).replace(/_/g, " ");
Severity: Minor
Found in rails/react-components/src/library/components/researcher-classes-form/index.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/user-report-form/index.tsx on lines 9..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              { student.can_remove ? <span className={css.link} role="link" onClick={this.handleRemoveStudent}>Remove Student</span> : undefined }
Severity: Minor
Found in rails/react-components/src/library/components/portal-classes/student-roster-row.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/portal-classes/student-roster-row.tsx on lines 34..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <input className={css.url} type="text" name="url" value={formData.url} onChange={handleFormInputChange} autoComplete="off"/>
Severity: Minor
Found in rails/react-components/src/library/components/permission-forms/manage-forms-tab/create-edit-permission-form.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/permission-forms/manage-forms-tab/create-edit-permission-form.tsx on lines 47..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const title = (str: any) => (str.charAt(0).toUpperCase() + str.slice(1)).replace(/_/g, " ");
Severity: Minor
Found in rails/react-components/src/library/components/user-report-form/index.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/researcher-classes-form/index.tsx on lines 8..8

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          <ul>
            <li>Create classes for your students and assign them activities</li>
            <li>Save student work</li>
            <li>Track student progress through activities</li>
          </ul>
Severity: Minor
Found in rails/react-components/src/library/components/signup/sideinfo.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/site-notices/notices.tsx on lines 41..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          <tr>
            <th>Notice</th>
            <th>Updated</th>
            <th>Options</th>
          </tr>
Severity: Minor
Found in rails/react-components/src/library/components/site-notices/notices.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/signup/sideinfo.tsx on lines 12..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <div><input className={css.name} type="text" name="name" value={formData.name} onChange={handleFormInputChange} autoComplete="off" /></div>
Severity: Minor
Found in rails/react-components/src/library/components/permission-forms/manage-forms-tab/create-edit-permission-form.tsx and 1 other location - About 50 mins to fix
rails/react-components/src/library/components/permission-forms/manage-forms-tab/create-edit-permission-form.tsx on lines 52..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                else if( !image.imgType && tokType & tok_type.URL ) {
                    image.imgUrl = tokVal;
                    image.imgType = 'image';
                }
                else if( isBgPosToken( token ) && !image.bgPosition ) {
Severity: Major
Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    while( (child = el.firstChild) ) {
                    cont.appendChild( child );
                }
    Severity: Major
    Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              for( i = 0; i < len; i++ ) {
                            renderers[i].updateSize();
                        }
      Severity: Major
      Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if( renderer.needsUpdate() ) {
                            renderer.updateProps();
                        }
        Severity: Major
        Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if( ( val.charAt(0) === 'r' ? isNumOrPct( next() ) : isNum( next() ) ) &&
                            isValue( next(), ',' ) &&
                            isNumOrPct( next() ) &&
                            isValue( next(), ',' ) &&
                            isNumOrPct( next() ) &&
          Severity: Major
          Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            else if( ( type & Type.URL ) && !p.src ) {
                    p.src =  value;
                }

                // Found something unrecognized; exit.
            Severity: Major
            Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if( image && image !== 'none' ) {
                                sizeParts = sizes[i].split( ' ' );
                                props.bgImages.push( {
                                    origString: image + ' ' + repeats[ i ] + ' ' + positions[ i ] + ' / ' + sizes[ i ] + ' ' +
                                                origins[ i ] + ' ' + clips[ i ],
              Severity: Major
              Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js - About 45 mins to fix
                Severity
                Category
                Status
                Source
                Language