Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/controllers/api/api_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check_for_auth_token has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

  def check_for_auth_token(params)
    header = request.headers["Authorization"]
    if header && header =~ /^Bearer (.*)$/i
      token = $1
      grant = AccessGrant.find_by_access_token(token)
Severity: Minor
Found in rails/app/controllers/api/api_controller.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_for_auth_token has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_for_auth_token(params)
    header = request.headers["Authorization"]
    if header && header =~ /^Bearer (.*)$/i
      token = $1
      grant = AccessGrant.find_by_access_token(token)
Severity: Major
Found in rails/app/controllers/api/api_controller.rb - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

            if user
          peer = Client.find_by_app_secret(token)
          if peer
            return [user, {:learner => nil, :teacher => nil}]
          else
    Severity: Major
    Found in rails/app/controllers/api/api_controller.rb - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

            return [current_user, nil]
      Severity: Major
      Found in rails/app/controllers/api/api_controller.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status