Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/controllers/interactives_controller.rb

Summary

Maintainability
D
1 day
Test Coverage

Method import_model_library has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def import_model_library
    authorize Interactive
    if request.post?
      respond_to do |format|
        begin
Severity: Minor
Found in rails/app/controllers/interactives_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    cancel = params[:commit] == "Cancel"
    @interactive = Interactive.find(params[:id])
    authorize @interactive
Severity: Minor
Found in rails/app/controllers/interactives_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update
    cancel = params[:commit] == "Cancel"
    @interactive = Interactive.find(params[:id])
    authorize @interactive
Severity: Minor
Found in rails/app/controllers/interactives_controller.rb - About 1 hr to fix

    Method import_model_library has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def import_model_library
    authorize Interactive
    if request.post?
      respond_to do |format|
        begin
    Severity: Minor
    Found in rails/app/controllers/interactives_controller.rb - About 1 hr to fix

      Method create has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create
    authorize Interactive
    @interactive = Interactive.new(interactive_strong_params(params[:interactive]))
    @interactive.user = current_visitor
      Severity: Minor
      Found in rails/app/controllers/interactives_controller.rb - About 1 hr to fix

        Method index has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def index
    authorize Interactive

    search_params = {
      :material_types       => [Search::InteractiveMaterial],
        Severity: Minor
        Found in rails/app/controllers/interactives_controller.rb - About 1 hr to fix

          Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
    authorize Interactive
    @interactive = Interactive.new(interactive_strong_params(params[:interactive]))
    @interactive.user = current_visitor
          Severity: Minor
          Found in rails/app/controllers/interactives_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              respond_to do |format|
      if @interactive.save
        format.js  # render the js file
        flash['notice'] = 'Interactive was successfully created.'
        format.html { redirect_to(@interactive) }
          Severity: Minor
          Found in rails/app/controllers/interactives_controller.rb and 1 other location - About 1 hr to fix
          rails/app/controllers/external_activities_controller.rb on lines 124..132

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def destroy
    @interactive = Interactive.find(params[:id])
    authorize @interactive
    @interactive.destroy
    @redirect = params[:redirect]
          Severity: Minor
          Found in rails/app/controllers/interactives_controller.rb and 1 other location - About 30 mins to fix
          rails/app/controllers/external_activities_controller.rb on lines 202..210

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status