Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/controllers/report/learner_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method arg_block has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def arg_block(learners)
    authoring_sites = learners.select { |l| l.runnable_type == "ExternalActivity" }.map do |learner|
      uri = URI(learner.runnable.url)
      "#{uri.scheme}://#{uri.host}:#{uri.port}"
    end
Severity: Minor
Found in rails/app/controllers/report/learner_controller.rb - About 1 hr to fix

    Method setup has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def setup
    @button_texts = {
      :apply => 'Apply Filters',
      :usage => 'Usage Report',
      :details => 'Details Report',
    Severity: Minor
    Found in rails/app/controllers/report/learner_controller.rb - About 1 hr to fix

      Method arg_block has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def arg_block(learners)
    authoring_sites = learners.select { |l| l.runnable_type == "ExternalActivity" }.map do |learner|
      uri = URI(learner.runnable.url)
      "#{uri.scheme}://#{uri.host}:#{uri.port}"
    end
      Severity: Minor
      Found in rails/app/controllers/report/learner_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def setup
    @button_texts = {
      :apply => 'Apply Filters',
      :usage => 'Usage Report',
      :details => 'Details Report',
      Severity: Minor
      Found in rails/app/controllers/report/learner_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status