Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/controllers/robots_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method sitemap has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def sitemap

    builder = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|

        xml.urlset('xmlns' => 'http://www.sitemaps.org/schemas/sitemap/0.9') {
Severity: Major
Found in rails/app/controllers/robots_controller.rb - About 2 hrs to fix

    Method sitemap has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def sitemap

    builder = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|

        xml.urlset('xmlns' => 'http://www.sitemaps.org/schemas/sitemap/0.9') {
    Severity: Minor
    Found in rails/app/controllers/robots_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method index has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def index
    if ENV['DYNAMIC_ROBOTS_TXT'] == 'true'

        lines = []
    Severity: Minor
    Found in rails/app/controllers/robots_controller.rb - About 1 hr to fix

      Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def index
    if ENV['DYNAMIC_ROBOTS_TXT'] == 'true'

        lines = []
      Severity: Minor
      Found in rails/app/controllers/robots_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status