Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/controllers/users_controller.rb

Summary

Maintainability
D
1 day
Test Coverage

Method update has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    if params[:commit] == "Cancel"
      redirect_to view_context.class_link_for_user
    else
      @user = User.find(params[:id])
Severity: Minor
Found in rails/app/controllers/users_controller.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update
    if params[:commit] == "Cancel"
      redirect_to view_context.class_link_for_user
    else
      @user = User.find(params[:id])
Severity: Minor
Found in rails/app/controllers/users_controller.rb - About 2 hrs to fix

    Method limited_update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def limited_update
    if params[:commit] == "Cancel"
      redirect_to users_path
    else
      @user = User.find(params[:id])
    Severity: Minor
    Found in rails/app/controllers/users_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method index has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def index
    authorize User

    user_type_conditions = []
    Severity: Minor
    Found in rails/app/controllers/users_controller.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  if params[:user][:has_projects_in_form]
              expiration_dates = params[:user][:project_expiration_dates] || {}
              can_manage_permission_forms = params[:user][:project_can_manage_permission_forms] || {}
              @user.set_role_for_projects('researcher', current_visitor.admin_for_projects, params[:user][:researcher_project_ids] || [], expiration_dates, can_manage_permission_forms)
            end
      Severity: Major
      Found in rails/app/controllers/users_controller.rb - About 45 mins to fix

        Method switch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def switch
    @user = User.find(params[:id])
    authorize @user
    if params[:commit] == "Switch"
      if switch_to_user = User.find(params[:user][:id])
        Severity: Minor
        Found in rails/app/controllers/users_controller.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if params[:user][:has_projects_in_form]
              expiration_dates = params[:user][:project_expiration_dates] || {}
              can_manage_permission_forms = params[:user][:project_can_manage_permission_forms] || {}
              @user.set_role_for_projects('researcher', current_visitor.admin_for_projects, params[:user][:researcher_project_ids] || [], expiration_dates, can_manage_permission_forms)
        Severity: Minor
        Found in rails/app/controllers/users_controller.rb and 1 other location - About 40 mins to fix
        rails/app/controllers/users_controller.rb on lines 259..262

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if params[:user][:has_projects_in_form]
          expiration_dates = params[:user][:project_expiration_dates] || {}
          can_manage_permission_forms = params[:user][:project_can_manage_permission_forms] || {}
          @user.set_role_for_projects('researcher', current_visitor.admin_for_projects, params[:user][:researcher_project_ids] || [], expiration_dates, can_manage_permission_forms)
        Severity: Minor
        Found in rails/app/controllers/users_controller.rb and 1 other location - About 40 mins to fix
        rails/app/controllers/users_controller.rb on lines 168..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status