concord-consortium/rigse

View on GitHub
rails/app/helpers/navigation_helper.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File navigation_helper.rb has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module NavigationHelper

  private

  def nav_label(key)
Severity: Minor
Found in rails/app/helpers/navigation_helper.rb - About 2 hrs to fix

    Method clazz_links_for_teacher has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def clazz_links_for_teacher
        clazzes = current_visitor.portal_teacher.clazzes.where(is_archived: false)
        clazz_links = [
          {
            id: "/classes",
    Severity: Major
    Found in rails/app/helpers/navigation_helper.rb - About 2 hrs to fix

      Method navigation_service has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def navigation_service(params={})
          _params = {
            name: current_visitor.name,
            request_path: request.path,
          }
      Severity: Minor
      Found in rails/app/helpers/navigation_helper.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status