Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/models/external_report.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method url_for_class has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def url_for_class(clazz, user, protocol, host, additional_params = {})
Severity: Minor
Found in rails/app/models/external_report.rb - About 35 mins to fix

    Method url_for_offering has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def url_for_offering(offering, user, protocol, host, additional_params = {})
    Severity: Minor
    Found in rails/app/models/external_report.rb - About 35 mins to fix

      Method offering_report_params has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def offering_report_params(offering, grant, user, url_options, additional_params = {})
      Severity: Minor
      Found in rails/app/models/external_report.rb - About 35 mins to fix

        Method url_for_offering has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def url_for_offering(offering, user, protocol, host, additional_params = {})
    grant = client.updated_grant_for(user, ReportTokenValidFor)
    if user.portal_teacher
      grant.teacher = user.portal_teacher
      grant.save!
        Severity: Minor
        Found in rails/app/models/external_report.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status