Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/models/security_question.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method make_questions_from_hash_and_user has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def self.make_questions_from_hash_and_user(hash, user = nil)
      hash = hash.with_indifferent_access
      (0..2).to_a.collect do |i|
        data = hash["question#{i}"]
        next if data.nil?
Severity: Minor
Found in rails/app/models/security_question.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method select_options has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def select_options
      options = []
      if self.question && !self.question.empty?
        options << "<option value=\"current\" selected>#{self.question}</option>".html_safe unless self.id.nil?
      else
Severity: Minor
Found in rails/app/models/security_question.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status