Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/lib/changeable.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method changeable? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def changeable?(user)
    # the Anonymous user can't change anything, always return false
    if(user.anonymous?)
      return false
Severity: Minor
Found in rails/lib/changeable.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method owned? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def owned?
    if self.respond_to? :user
      if self.user.nil?
        return false
      end
Severity: Minor
Found in rails/lib/changeable.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status