Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/lib/mock_data/create_default_data.rb

Summary

Maintainability
F
6 days
Test Coverage

Method create_default_users has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

  def self.create_default_users
    puts
    puts
    admin_info = DEFAULT_DATA[:admin_settings]
    settings = Admin::Settings.find_by_uuid(admin_info[:uuid])
Severity: Minor
Found in rails/lib/mock_data/create_default_data.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_default_users has 293 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.create_default_users
    puts
    puts
    admin_info = DEFAULT_DATA[:admin_settings]
    settings = Admin::Settings.find_by_uuid(admin_info[:uuid])
Severity: Major
Found in rails/lib/mock_data/create_default_data.rb - About 1 day to fix

    File create_default_data.rb has 556 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module MockData

  current_dir = File.dirname(__FILE__)
  default_data = {}
    Severity: Major
    Found in rails/lib/mock_data/create_default_data.rb - About 1 day to fix

      Method create_default_clazzes has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.create_default_clazzes
    # this method creates default classes,
    # teacher class mapping
    # student class mapping
      Severity: Minor
      Found in rails/lib/mock_data/create_default_data.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_default_clazzes has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.create_default_clazzes
    # this method creates default classes,
    # teacher class mapping
    # student class mapping
      Severity: Major
      Found in rails/lib/mock_data/create_default_data.rb - About 2 hrs to fix

        Method create_default_assignments_for_class has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.create_default_assignments_for_class
    #this method assigns study materials to the classes
    DEFAULT_DATA[:assignments].each do |assignment_key, assignment|
      clazz = @default_classes.find{|c| c.name == assignment[:class_name]}
      if clazz
        Severity: Minor
        Found in rails/lib/mock_data/create_default_data.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add_default_user has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.add_default_user(user_info)

    default_password = APP_CONFIG[:password_for_default_users]
    user = nil
    user_by_email = nil
        Severity: Minor
        Found in rails/lib/mock_data/create_default_data.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create_default_study_materials has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.create_default_study_materials
    default_external_activities = []
    @default_external_activities = default_external_activities

    # External Activity
        Severity: Minor
        Found in rails/lib/mock_data/create_default_data.rb - About 1 hr to fix

          Method add_default_user has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.add_default_user(user_info)

    default_password = APP_CONFIG[:password_for_default_users]
    user = nil
    user_by_email = nil
          Severity: Minor
          Found in rails/lib/mock_data/create_default_data.rb - About 1 hr to fix

            Method create_default_assignments_for_class has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def self.create_default_assignments_for_class
    #this method assigns study materials to the classes
    DEFAULT_DATA[:assignments].each do |assignment_key, assignment|
      clazz = @default_classes.find{|c| c.name == assignment[:class_name]}
      if clazz
            Severity: Minor
            Found in rails/lib/mock_data/create_default_data.rb - About 1 hr to fix

              Method create_default_study_materials has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.create_default_study_materials
    default_external_activities = []
    @default_external_activities = default_external_activities

    # External Activity
              Severity: Minor
              Found in rails/lib/mock_data/create_default_data.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method create_default_interactives has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.create_default_interactives
    puts
    puts
    count = 0
    Interactive.destroy_all
              Severity: Minor
              Found in rails/lib/mock_data/create_default_data.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  DEFAULT_DATA[:teacher_clazzes].each do |teacher_clazz, teacher_clazz_info|
      map_teacher = @default_teachers.find{|t| t.user.login == teacher_clazz_info[:teacher]}
      if map_teacher
        clazz_names = teacher_clazz_info[:clazz_names].split(",").map{|c| c.strip }
        clazz_names.each do |clazz_name|
              Severity: Major
              Found in rails/lib/mock_data/create_default_data.rb and 1 other location - About 1 hr to fix
              rails/lib/mock_data/create_default_data.rb on lines 482..489

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  DEFAULT_DATA[:student_clazzes].each do |student_clazz, student_clazz_info|
      map_student = @default_students.find{|s| s.user.login == student_clazz_info[:student]}
      if map_student
        clazz_names = student_clazz_info[:clazz_names].split(",").map{|c| c.strip }
        clazz_names.each do |clazz_name|
              Severity: Major
              Found in rails/lib/mock_data/create_default_data.rb and 1 other location - About 1 hr to fix
              rails/lib/mock_data/create_default_data.rb on lines 468..475

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status