Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/lib/role_requirement_system.rb

Summary

Maintainability
C
1 day
Test Coverage

Method user_authorized_for? has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

    def user_authorized_for?(user, params = {}, binding = self.binding)
      return true unless Array===self.role_requirements
      self.role_requirements.each{| role_requirement|
        roles = role_requirement[:roles]
        options = role_requirement[:options]
Severity: Minor
Found in rails/lib/role_requirement_system.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method require_role has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def require_role(roles, options = {})
      options.assert_valid_keys(:if, :unless,
        :for, :only,
        :for_all_except, :except
      )
Severity: Minor
Found in rails/lib/role_requirement_system.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status