Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/lib/searchable_model.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method search has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def search(search, page, user, includes={}, policy_scope=nil)
    sql_parameters = []
    sql_conditions = ""
    # pass in a username to limit the search to the users items
    if (!user.nil?) && (!user.id.nil?)
Severity: Minor
Found in rails/lib/searchable_model.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method search has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def search(search, page, user, includes={}, policy_scope=nil)
    sql_parameters = []
    sql_conditions = ""
    # pass in a username to limit the search to the users items
    if (!user.nil?) && (!user.id.nil?)
Severity: Minor
Found in rails/lib/searchable_model.rb - About 1 hr to fix

    Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def search(search, page, user, includes={}, policy_scope=nil)
    Severity: Minor
    Found in rails/lib/searchable_model.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status