Sign upLogin

concordia-publishing-house/errbit

View on GitHub
Star
lib/data_migration.rb

Summary

Maintainability
C
1 day
Test Coverage

File data_migration.rb has 384 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'mongo'

include Mongo

class ActiveRecord::Base
Severity: Minor
Found in lib/data_migration.rb - About 5 hrs to fix

    Class Worker has 33 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Worker
    # mapping should be a hash {:key_to => :key_from}
    # value of this hash can be an object and respond to :call, which returns value for new key
    USER_FIELDS_MAPPING = {
      :remote_id => lambda{|v| v["_id"].to_s},
    Severity: Minor
    Found in lib/data_migration.rb - About 4 hrs to fix

      Method copy_attributes_with_mapping has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def copy_attributes_with_mapping(map_hash, copy_from, copy_to)
        map_hash.each do |to_key, from_key|
          if from_key.respond_to? :call
            copy_to.send("#{to_key}=", from_key.call(copy_from))
          else
      Severity: Minor
      Found in lib/data_migration.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def copy_issue_tracker(app, old_app)
        return unless old_app["issue_tracker"]
        issue_tracker = app.build_issue_tracker
        copy_attributes_with_mapping(ISSUE_TRACKER_FIELDS_MAPPING, old_app["issue_tracker"], issue_tracker)
        app.issue_tracker.type = normalize_issue_tracker_classname(old_app["issue_tracker"]["_type"])
      Severity: Minor
      Found in lib/data_migration.rb and 1 other location - About 25 mins to fix
      lib/data_migration.rb on lines 415..422

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def copy_notification_service(app, old_app)
        return unless old_app["notification_service"]
        notification_service = app.build_notification_service
        copy_attributes_with_mapping(NOTIFICATION_SERVICE_FIELDS_MAPPING, old_app["notification_service"], notification_service)
        app.notification_service.type = normalize_notification_service_classname(old_app["notification_service"]["_type"])
      Severity: Minor
      Found in lib/data_migration.rb and 1 other location - About 25 mins to fix
      lib/data_migration.rb on lines 405..412

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status