condorrocks/condor

View on GitHub

Showing 200 of 200 total issues

The variable $URL is not named in camelCase.
Open

    public function editMonitor($monitorId, $monitorStatus = null, $friendlyName = null, $URL = null, $subType = null, $port = null, $keywordType = null, $keywordValue = null, $HTTPUsername = null, $HTTPPassword = null, $alertContacts = null)
    {
        $url = $this->base_uri.'/editMonitor?monitorID='.$monitorId;

        if (isset($monitorStatus)) {

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $HTTPUsername is not named in camelCase.
Open

    public function editMonitor($monitorId, $monitorStatus = null, $friendlyName = null, $URL = null, $subType = null, $port = null, $keywordType = null, $keywordValue = null, $HTTPUsername = null, $HTTPPassword = null, $alertContacts = null)
    {
        $url = $this->base_uri.'/editMonitor?monitorID='.$monitorId;

        if (isset($monitorStatus)) {

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $file_contents is not named in camelCase.
Open

    private function __fetch($url)
    {
        if (empty($url)) {
            throw new \Exception('Value not specified: url', 1);
        }

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $HTTPPassword is not named in camelCase.
Open

    public function newMonitor($friendlyName, $URL, $type, $subType = null, $port = null, $keywordType = null, $keywordValue = null, $HTTPUsername = null, $HTTPPassword = null, $alertContacts = null, $monitorInterval = 5)
    {
        if (empty($friendlyName) || empty($URL) || empty($type)) {
            throw new \Exception('Required key "name", "uri" or "type" not specified', 3);
        }

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $HTTPPassword is not named in camelCase.
Open

    public function editMonitor($monitorId, $monitorStatus = null, $friendlyName = null, $URL = null, $subType = null, $port = null, $keywordType = null, $keywordValue = null, $HTTPUsername = null, $HTTPPassword = null, $alertContacts = null)
    {
        $url = $this->base_uri.'/editMonitor?monitorID='.$monitorId;

        if (isset($monitorStatus)) {

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $alert_to is not named in camelCase.
Open

    public function setAlertToAttribute($alert_to)
    {
        $this->attributes['alert_to'] = trim($alert_to) ?: null;
    }
Severity: Minor
Found in app/Board.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $URL is not named in camelCase.
Open

    public function newMonitor($friendlyName, $URL, $type, $subType = null, $port = null, $keywordType = null, $keywordValue = null, $HTTPUsername = null, $HTTPPassword = null, $alertContacts = null, $monitorInterval = 5)
    {
        if (empty($friendlyName) || empty($URL) || empty($type)) {
            throw new \Exception('Required key "name", "uri" or "type" not specified', 3);
        }

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $HTTPPassword is not named in camelCase.
Open

    public function editMonitor($monitorId, $monitorStatus = null, $friendlyName = null, $URL = null, $subType = null, $port = null, $keywordType = null, $keywordValue = null, $HTTPUsername = null, $HTTPPassword = null, $alertContacts = null)
    {
        $url = $this->base_uri.'/editMonitor?monitorID='.$monitorId;

        if (isset($monitorStatus)) {

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $HTTPPassword is not named in camelCase.
Open

    public function testEditMonitor()
    {
        $this->assertNotEquals(null, $this->object->editMonitor($monitorId = static::$newMonitorId, $monitorStatus = 0, $friendlyName = 'Edit 1', $URL = 'http://google.com', $subType = null, $port = null, $keywordType = null, $keywordValue = null, $HTTPUsername = null, $HTTPPassword = null));
    }

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method testSetFormat_1 is not named in camelCase.
Open

    public function testSetFormat_1()
    {
        $this->assertEquals(0, $this->object->setFormat('xml'));
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testGetMonitors_created is not named in camelCase.
Open

    public function testGetMonitors_created()
    {
        $this->assertNotEquals(null, $this->object->getMonitors($monitors = static::$newMonitorId, $customUptimeRatio = null, $logs = 1, $responseTimes = 1, $responseTimesAverage = 1, $alertContacts = 1, $showMonitorAlertContacts = 1, $showTimezone = 1));
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method __fetch is not named in camelCase.
Open

    private function __fetch($url)
    {
        if (empty($url)) {
            throw new \Exception('Value not specified: url', 1);
        }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testSetFormat_2 is not named in camelCase.
Open

    public function testSetFormat_2()
    {
        $this->assertEquals(0, $this->object->setFormat('json'));
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testDeleteMonitor_1 is not named in camelCase.
Open

    public function testDeleteMonitor_1()
    {
        $this->assertNotEquals(null, $this->object->deleteMonitor(static::$newMonitorId));
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testGetApiKey_whitoutConf is not named in camelCase.
Open

    public function testGetApiKey_whitoutConf()
    {
        $this->object->getApiKey();
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testDeleteMonitor_whitout_params is not named in camelCase.
Open

    public function testDeleteMonitor_whitout_params()
    {
        $this->object->deleteMonitor();
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testGetAlertContacts_all is not named in camelCase.
Open

    public function testGetAlertContacts_all()
    {
        $this->assertNotEquals(null, $this->object->getAlertContacts());
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testSetFormat_err is not named in camelCase.
Open

    public function testSetFormat_err()
    {
        $this->object->setFormat('test');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testGetMonitors_1 is not named in camelCase.
Open

    public function testGetMonitors_1()
    {
        $this->assertNotEquals(null, $this->object->getMonitors());
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method testGetAlertContacts_created is not named in camelCase.
Open

    public function testGetAlertContacts_created()
    {
        $this->assertNotEquals(null, $this->object->getAlertContacts(static::$newUserId));
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language