connectbot/sshlib

View on GitHub

Showing 412 of 412 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

public static class CTR extends Wrapper {
@Override
public void init(boolean forEncryption, byte[] key, byte[] iv) throws IllegalArgumentException {
BlockCipher rawCipher = new BlowFish();
rawCipher.init(true, key, iv);
Severity: Minor
Found in src/main/java/com/trilead/ssh2/crypto/cipher/BlowFish.java and 1 other location - About 30 mins to fix
src/main/java/com/trilead/ssh2/crypto/cipher/DESede.java on lines 122..129

Avoid too many return statements within this method.
Open

return;
Severity: Major
Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

    return;
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

      return len;
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/crypto/SimpleDERReader.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

        return;
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

          return;
          Severity: Major
          Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

            return;
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

              return;
              Severity: Major
              Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                return;
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                  return ECDSASHA2NISTP256Verify.get();
                  Severity: Major
                  Found in src/main/java/com/trilead/ssh2/signature/ECDSASHA2Verify.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                    return;
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                      return false;
                      Severity: Major
                      Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                        return false;
                        Severity: Major
                        Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                          return true;
                          Severity: Major
                          Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                            synchronized (c.channelSendLock)
                            {
                            if (c.closeMessageSent)
                            throw new IOException("Cannot start shell on this channel (" + c.getReasonClosed() + ")");
                            tm.sendMessage(sm.getPayload());
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 6 other locations - About 30 mins to fix
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 661..666
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 697..702
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 730..735
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 755..760
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 790..795
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 822..827

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                            synchronized (c.channelSendLock)
                            {
                            if (c.closeMessageSent)
                            throw new IOException("Cannot request subsystem on this channel (" + c.getReasonClosed() + ")");
                            tm.sendMessage(ssr.getPayload());
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 6 other locations - About 30 mins to fix
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 661..666
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 697..702
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 730..735
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 755..760
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 822..827
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 857..862

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                            synchronized (c.channelSendLock)
                            {
                            if (c.closeMessageSent)
                            throw new IOException("Cannot ping this channel (" + c.getReasonClosed() + ")");
                            tm.sendMessage(pctp.getPayload());
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 6 other locations - About 30 mins to fix
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 697..702
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 730..735
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 755..760
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 790..795
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 822..827
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 857..862

                            Avoid too many return statements within this method.
                            Open

                            return false;
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                              return true;
                              Severity: Major
                              Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                return false;
                                Severity: Major
                                Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language