connectbot/sshlib

View on GitHub

Showing 412 of 412 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static class CTR extends Wrapper {
        @Override
        public void init(boolean forEncryption, byte[] key, byte[] iv) throws IllegalArgumentException {
            BlockCipher rawCipher = new DESede();
            rawCipher.init(true, key, iv);
Severity: Minor
Found in src/main/java/com/trilead/ssh2/crypto/cipher/DESede.java and 1 other location - About 30 mins to fix
src/main/java/com/trilead/ssh2/crypto/cipher/BlowFish.java on lines 427..434

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

                return;
Severity: Major
Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return;
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return len;
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/crypto/SimpleDERReader.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return;
          Severity: Major
          Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return;
            Severity: Major
            Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return;
              Severity: Major
              Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return;
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return false;
                  Severity: Major
                  Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return;
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return true;
                      Severity: Major
                      Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return false;
                        Severity: Major
                        Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return false;
                          Severity: Major
                          Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                    synchronized (c.channelSendLock)
                                    {
                                        if (c.closeMessageSent)
                                            throw new IOException("Cannot request PTY on this channel (" + c.getReasonClosed() + ")");
                                        tm.sendMessage(spr.getPayload());
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 6 other locations - About 30 mins to fix
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 661..666
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 730..735
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 755..760
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 790..795
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 822..827
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 857..862

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 40.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                    synchronized (c.channelSendLock)
                                    {
                                        if (c.closeMessageSent)
                                            throw new IOException("Cannot request subsystem on this channel (" + c.getReasonClosed() + ")");
                                        tm.sendMessage(ssr.getPayload());
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 6 other locations - About 30 mins to fix
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 661..666
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 697..702
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 730..735
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 755..760
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 822..827
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 857..862

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 40.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                    synchronized (c.channelSendLock)
                                    {
                                        if (c.closeMessageSent)
                                            throw new IOException("Cannot ping this channel (" + c.getReasonClosed() + ")");
                                        tm.sendMessage(pctp.getPayload());
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 6 other locations - About 30 mins to fix
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 697..702
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 730..735
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 755..760
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 790..795
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 822..827
                            src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 857..862

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 40.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Avoid too many return statements within this method.
                            Open

                                        return ECDSASHA2NISTP256Verify.get();
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/signature/ECDSASHA2Verify.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return false;
                              Severity: Major
                              Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                                Similar blocks of code found in 7 locations. Consider refactoring.
                                Open

                                        synchronized (c.channelSendLock)
                                        {
                                            if (c.closeMessageSent)
                                                throw new IOException("Cannot execute command on this channel (" + c.getReasonClosed() + ")");
                                            tm.sendMessage(sm.getPayload());
                                Severity: Major
                                Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java and 6 other locations - About 30 mins to fix
                                src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 661..666
                                src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 697..702
                                src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 730..735
                                src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 755..760
                                src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 790..795
                                src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 857..862

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 40.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language