Sign upLogin

connectbot/sshlib

View on GitHub
Star
src/main/java/com/trilead/ssh2/KnownHosts.java

Summary

Maintainability
F
6 days
Test Coverage
F
44%

File KnownHosts.java has 601 lines of code (exceeds 250 allowed). Consider refactoring.
Open


package com.trilead.ssh2;

import java.io.BufferedReader;
import java.io.CharArrayReader;
Severity: Major
Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 day to fix

    Method pseudoRegex has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
    Open

        private final boolean pseudoRegex(char[] pattern, int i, char[] match, int j)
    {
        /* This matching logic is equivalent to the one present in OpenSSH 4.1 */

        while (true)
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method hostnameMatches has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

        private final boolean hostnameMatches(String[] hostpatterns, String hostname)
    {
        boolean isMatch = false;
        boolean negate = false;
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    KnownHosts has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class KnownHosts
{
    public static final int HOSTKEY_IS_OK = 0;
    public static final int HOSTKEY_IS_NEW = 1;
    public static final int HOSTKEY_HAS_CHANGED = 2;
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 2 hrs to fix

      Method hostnameMatches has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private final boolean hostnameMatches(String[] hostpatterns, String hostname)
    {
        boolean isMatch = false;
        boolean negate = false;
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 2 hrs to fix

        Method verifyHostkey has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public int verifyHostkey(String hostname, String serverHostKeyAlgorithm, byte[] serverHostKey) throws IOException
    {
        PublicKey remoteKey = null;

        if (RSASHA1Verify.ID_SSH_RSA.equals(serverHostKeyAlgorithm) ||
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

          Method addHostkey has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void addHostkey(String[] hostnames, String serverHostKeyAlgorithm, byte[] serverHostKey) throws IOException
    {
        if (hostnames == null)
            throw new IllegalArgumentException("hostnames may not be null");
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

            Method verifyHostkey has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public int verifyHostkey(String hostname, String serverHostKeyAlgorithm, byte[] serverHostKey) throws IOException
    {
        PublicKey remoteKey = null;

        if (RSASHA1Verify.ID_SSH_RSA.equals(serverHostKeyAlgorithm) ||
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method rawFingerPrint has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private static byte[] rawFingerPrint(String type, String keyType, byte[] hostkey)
    {
        MessageDigest dig = null;

        try {
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

              Method pseudoRegex has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private final boolean pseudoRegex(char[] pattern, int i, char[] match, int j)
    {
        /* This matching logic is equivalent to the one present in OpenSSH 4.1 */

        while (true)
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                Method addHostkeyToFile has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public final static void addHostkeyToFile(File knownHosts, String[] hostnames, String serverHostKeyAlgorithm,
            byte[] serverHostKey) throws IOException
    {
        if ((hostnames == null) || (hostnames.length == 0))
            throw new IllegalArgumentException("Need at least one hostname specification");
                Severity: Minor
                Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                  Method addHostkeyToFile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public final static void addHostkeyToFile(File knownHosts, String[] hostnames, String serverHostKeyAlgorithm,
            byte[] serverHostKey) throws IOException
    {
        if ((hostnames == null) || (hostnames.length == 0))
            throw new IllegalArgumentException("Need at least one hostname specification");
                  Severity: Minor
                  Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method rawFingerPrint has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private static byte[] rawFingerPrint(String type, String keyType, byte[] hostkey)
    {
        MessageDigest dig = null;

        try {
                  Severity: Minor
                  Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method recommendHostkeyAlgorithms has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private String[] recommendHostkeyAlgorithms(String hostname) {
        List<String> preferredAlgos = new ArrayList<>();

        List<PublicKey> keys = getAllKeys(hostname);
                  Severity: Minor
                  Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method checkHashed has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private final boolean checkHashed(String entry, String hostname)
    {
        if (!entry.startsWith("|1|"))
            return false;
                  Severity: Minor
                  Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                    Method rawToBubblebabbleFingerprint has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        static final private String rawToBubblebabbleFingerprint(byte[] raw)
    {
        final char[] v = "aeiouy".toCharArray();
        final char[] c = "bcdfghklmnprstvzx".toCharArray();
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                      Method recommendHostkeyAlgorithms has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private String[] recommendHostkeyAlgorithms(String hostname) {
        List<String> preferredAlgos = new ArrayList<>();

        List<PublicKey> keys = getAllKeys(hostname);
                      Severity: Minor
                      Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 1 hr to fix

                        Method addHostkey has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public void addHostkey(String[] hostnames, String serverHostKeyAlgorithm, byte[] serverHostKey) throws IOException
    {
        if (hostnames == null)
            throw new IllegalArgumentException("hostnames may not be null");
                        Severity: Minor
                        Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method rawToBubblebabbleFingerprint has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            static final private String rawToBubblebabbleFingerprint(byte[] raw)
    {
        final char[] v = "aeiouy".toCharArray();
        final char[] c = "bcdfghklmnprstvzx".toCharArray();
                        Severity: Minor
                        Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid deeply nested control flow statements.
                        Open

                                                if (match.length == j)
                            return false;
                        Severity: Major
                        Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 45 mins to fix

                          Method checkHashed has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private final boolean checkHashed(String entry, String hostname)
    {
        if (!entry.startsWith("|1|"))
            return false;
                          Severity: Minor
                          Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid deeply nested control flow statements.
                          Open

                                                  if ((pattern[i] == match[j]) && pseudoRegex(pattern, i + 1, match, j + 1))
                            return true;
                          Severity: Major
                          Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 45 mins to fix

                            Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private void initialize(char[] knownHostsData) throws IOException
    {
        BufferedReader br = new BufferedReader(new CharArrayReader(knownHostsData));

        while (true)
                            Severity: Minor
                            Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Avoid too many return statements within this method.
                            Open

                                                    return false;
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return true;
                              Severity: Major
                              Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return false;
                                Severity: Major
                                Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                  return false;
                                  Severity: Major
                                  Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                    return false;
                                    Severity: Major
                                    Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                              return true;
                                      Severity: Major
                                      Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 30 mins to fix

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                for (int i = 0; i < hostnames.length; i++)
        {
            if (i != 0)
                writer.write(',');
            writer.write(hostnames[i]);
                                        Severity: Minor
                                        Found in src/main/java/com/trilead/ssh2/KnownHosts.java and 1 other location - About 40 mins to fix
                                        src/main/java/com/trilead/ssh2/packets/TypesWriter.java on lines 158..163

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 50.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Identical blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                while (true)
        {
            int len = fr.read(buff);
            if (len < 0)
                break;
                                        Severity: Minor
                                        Found in src/main/java/com/trilead/ssh2/KnownHosts.java and 1 other location - About 30 mins to fix
                                        src/main/java/com/trilead/ssh2/Connection.java on lines 418..424

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 40.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        There are no issues that match your filters.

                                        Category
                                        Status