Sign upLogin

connectbot/sshlib

View on GitHub
Star
src/main/java/com/trilead/ssh2/SCPClient.java

Summary

Maintainability
F
5 days
Test Coverage
F
0%

File SCPClient.java has 448 lines of code (exceeds 250 allowed). Consider refactoring.
Open


package com.trilead.ssh2;

import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
Severity: Minor
Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 6 hrs to fix

    Method receiveFiles has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        private void receiveFiles(Session sess, String[] files, String target) throws IOException
    {
        byte[] buffer = new byte[8192];

        OutputStream os = new BufferedOutputStream(sess.getStdin(), 512);
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method receiveFiles has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private void receiveFiles(Session sess, OutputStream[] targets) throws IOException
    {
        byte[] buffer = new byte[8192];

        OutputStream os = new BufferedOutputStream(sess.getStdin(), 512);
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method receiveFiles has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void receiveFiles(Session sess, String[] files, String target) throws IOException
    {
        byte[] buffer = new byte[8192];

        OutputStream os = new BufferedOutputStream(sess.getStdin(), 512);
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 2 hrs to fix

      Method sendFiles has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          private void sendFiles(Session sess, String[] files, String[] remoteFiles, String mode) throws IOException
    {
        byte[] buffer = new byte[8192];

        OutputStream os = new BufferedOutputStream(sess.getStdin(), 40000);
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sendFiles has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void sendFiles(Session sess, String[] files, String[] remoteFiles, String mode) throws IOException
    {
        byte[] buffer = new byte[8192];

        OutputStream os = new BufferedOutputStream(sess.getStdin(), 40000);
      Severity: Major
      Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 2 hrs to fix

        Method receiveFiles has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void receiveFiles(Session sess, OutputStream[] targets) throws IOException
    {
        byte[] buffer = new byte[8192];

        OutputStream os = new BufferedOutputStream(sess.getStdin(), 512);
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

          Method put has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public void put(String[] localFiles, String[] remoteFiles, String remoteTargetDirectory, String mode)
            throws IOException
    {
        Session sess = null;
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method put has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void put(String[] localFiles, String[] remoteFiles, String remoteTargetDirectory, String mode)
            throws IOException
    {
        Session sess = null;
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

            Method get has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private void get(String remoteFiles[], OutputStream[] targets) throws IOException
    {
        Session sess = null;

        if ((remoteFiles == null) || (targets == null))
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

              Method get has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void get(String remoteFiles[], OutputStream[] targets) throws IOException
    {
        Session sess = null;

        if ((remoteFiles == null) || (targets == null))
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public void get(String remoteFiles[], String localTargetDirectory) throws IOException
    {
        Session sess = null;

        if ((remoteFiles == null) || (localTargetDirectory == null))
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

                Method parseCLine has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private LenNamePair parseCLine(String line) throws IOException
    {
        /* Minimum line: "xxxx y z" ---> 8 chars */

        long len;
                Severity: Minor
                Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

                  Method get has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public void get(String remoteFiles[], String localTargetDirectory) throws IOException
    {
        Session sess = null;

        if ((remoteFiles == null) || (localTargetDirectory == null))
                  Severity: Minor
                  Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method put has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public void put(byte[] data, String remoteFileName, String remoteTargetDirectory, String mode) throws IOException
    {
        Session sess = null;

        if ((remoteFileName == null) || (remoteTargetDirectory == null) || (mode == null))
                  Severity: Minor
                  Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 1 hr to fix

                    Method put has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public void put(byte[] data, String remoteFileName, String remoteTargetDirectory, String mode) throws IOException
    {
        Session sess = null;

        if ((remoteFileName == null) || (remoteTargetDirectory == null) || (mode == null))
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method parseCLine has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private LenNamePair parseCLine(String line) throws IOException
    {
        /* Minimum line: "xxxx y z" ---> 8 chars */

        long len;
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method receiveLine has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private String receiveLine(InputStream is) throws IOException
    {
        StringBuffer sb = new StringBuffer(30);

        while (true)
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                while (true)
            {
                int c = is.read();
                if (c < 0)
                    throw new IOException("Remote scp terminated unexpectedly.");
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 1 hr to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 257..282

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 122.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                while (true)
            {
                int c = is.read();
                if (c < 0)
                    throw new IOException("Remote scp terminated unexpectedly.");
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 1 hr to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 330..355

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 122.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            for (int i = 0; i < remoteFiles.length; i++)
        {
            if (remoteFiles[i] == null)
                throw new IllegalArgumentException("Cannot accept null filename.");
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 1 hr to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 666..677

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 84.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            for (int i = 0; i < remoteFiles.length; i++)
        {
            if (remoteFiles[i] == null)
                throw new IllegalArgumentException("Cannot accept null filename.");
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 1 hr to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 718..729

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 84.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            try
        {
            sess = conn.openSession();
            sess.execCommand(cmd);
            sendFiles(sess, localFiles, remoteFiles, mode);
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 50 mins to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 533..547

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            try
        {
            sess = conn.openSession();
            sess.execCommand(cmd);
            sendBytes(sess, data, remoteFileName, mode);
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 50 mins to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 602..616

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            for (int i = 0; i < mode.length(); i++)
            if (!Character.isDigit(mode.charAt(i)))
                throw new IllegalArgumentException("Invalid mode.");
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 30 mins to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 584..586

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            for (int i = 0; i < mode.length(); i++)
            if (!Character.isDigit(mode.charAt(i)))
                throw new IllegalArgumentException("Invalid mode.");
                    Severity: Minor
                    Found in src/main/java/com/trilead/ssh2/SCPClient.java and 1 other location - About 30 mins to fix
                    src/main/java/com/trilead/ssh2/SCPClient.java on lines 524..526

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status