Sign upLogin

connectbot/sshlib

View on GitHub
Star
src/main/java/com/trilead/ssh2/Session.java

Summary

Maintainability
C
1 day
Test Coverage
F
16%

Method requestX11Forwarding has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void requestX11Forwarding(String hostname, int port, byte[] cookie, boolean singleConnection)
            throws IOException
    {
        if (hostname == null)
            throw new IllegalArgumentException("hostname argument may not be null");
Severity: Minor
Found in src/main/java/com/trilead/ssh2/Session.java - About 1 hr to fix

    Method requestX11Forwarding has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public void requestX11Forwarding(String hostname, int port, byte[] cookie, boolean singleConnection)
            throws IOException
    {
        if (hostname == null)
            throw new IllegalArgumentException("hostname argument may not be null");
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/Session.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method requestPTY has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public void requestPTY(String term, int term_width_characters, int term_height_characters, int term_width_pixels,
            int term_height_pixels, byte[] terminal_modes) throws IOException
    {
        if (term == null)
            throw new IllegalArgumentException("TERM cannot be null.");
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/Session.java - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method requestPTY has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void requestPTY(String term, int term_width_characters, int term_height_characters, int term_width_pixels,
            int term_height_pixels, byte[] terminal_modes) throws IOException
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/Session.java - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (int i = 0; i < fakeCookie.length; i++)
            {
                String digit2 = Integer.toHexString(fakeCookie[i] & 0xff);
                tmp.append((digit2.length() == 2) ? digit2 : "0" + digit2);
            }
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/Session.java and 1 other location - About 1 hr to fix
      src/main/java/com/trilead/ssh2/channel/RemoteX11AcceptThread.java on lines 140..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public void execCommand(String cmd) throws IOException
    {
        if (cmd == null)
            throw new IllegalArgumentException("cmd argument may not be null");
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/Session.java and 1 other location - About 50 mins to fix
      src/main/java/com/trilead/ssh2/Session.java on lines 311..329

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public void startSubSystem(String name) throws IOException
    {
        if (name == null)
            throw new IllegalArgumentException("name argument may not be null");
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/Session.java and 1 other location - About 50 mins to fix
      src/main/java/com/trilead/ssh2/Session.java on lines 262..280

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              synchronized (this)
        {
            /* The following is just a nicer error, we would catch it anyway later in the channel code */
            if (flag_closed)
                throw new IOException("This session is closed.");
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/Session.java and 1 other location - About 35 mins to fix
      src/main/java/com/trilead/ssh2/Session.java on lines 185..199

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              synchronized (this)
        {
            /* The following is just a nicer error, we would catch it anyway later in the channel code */
            if (flag_closed)
                throw new IOException("This session is closed.");
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/Session.java and 1 other location - About 35 mins to fix
      src/main/java/com/trilead/ssh2/Session.java on lines 113..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status