Sign upLogin

connectbot/sshlib

View on GitHub
Star
src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java

Summary

Maintainability
F
3 days
Test Coverage
D
62%

File AuthenticationManager.java has 418 lines of code (exceeds 250 allowed). Consider refactoring.
Open


package com.trilead.ssh2.auth;

import com.trilead.ssh2.crypto.keys.Ed25519PrivateKey;
import com.trilead.ssh2.crypto.keys.Ed25519PublicKey;
Severity: Minor
Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 6 hrs to fix

    Method authenticatePublicKey has 136 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public boolean authenticatePublicKey(String user, KeyPair pair, SecureRandom rnd, SignatureProxy signatureProxy)
            throws IOException
    {
        PrivateKey privateKey = null;
        PublicKey publicKey = null;
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 5 hrs to fix

      Method authenticatePublicKey has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean authenticatePublicKey(String user, KeyPair pair, SecureRandom rnd, SignatureProxy signatureProxy)
            throws IOException
    {
        PrivateKey privateKey = null;
        PublicKey publicKey = null;
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method authenticateInteractive has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public boolean authenticateInteractive(String user, String[] submethods, InteractiveCallback cb) throws IOException
    {
        try
        {
            initialize(user);
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 1 hr to fix

        Method authenticateInteractive has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public boolean authenticateInteractive(String user, String[] submethods, InteractiveCallback cb) throws IOException
    {
        try
        {
            initialize(user);
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private boolean initialize(String user) throws IOException
    {
        if (!initDone)
        {
            tm.registerMessageHandler(this, 0, 255);
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (msg[0] == Packets.SSH_MSG_USERAUTH_FAILURE)
            {
                PacketUserauthFailure puf = new PacketUserauthFailure(msg, 0, msg.length);

                remainingMethods = puf.getAuthThatCanContinue();
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 45 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 488..496

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (ar[0] == Packets.SSH_MSG_USERAUTH_FAILURE)
        {
            PacketUserauthFailure puf = new PacketUserauthFailure(ar, 0, ar.length);

            remainingMethods = puf.getAuthThatCanContinue();
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 45 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 156..163

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (signatureProxy != null)
                    {
                        rsa_sig_enc = signatureProxy.sign(msg, SignatureProxy.SHA1);
                    }
                    else
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 35 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 263..270

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (signatureProxy != null)
                    {
                        rsa_sig_enc = signatureProxy.sign(msg, SignatureProxy.SHA256);
                    }
                    else
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 35 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 276..284

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (signatureProxy != null)
                    {
                        rsa_sig_enc = signatureProxy.sign(msg, SignatureProxy.SHA512);
                    }
                    else
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 35 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 220..227

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (signatureProxy != null)
                {
                    ds_enc = signatureProxy.sign(msg, SignatureProxy.SHA1);
                }
                else
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 35 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 249..256

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (int i = 0; i < remainingMethods.length; i++)
        {
            if (remainingMethods[i].compareTo(methName) == 0)
                return true;
        }
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 30 mins to fix
          src/main/java/com/trilead/ssh2/Connection.java on lines 1127..1131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (msg[0] == Packets.SSH_MSG_USERAUTH_SUCCESS)
            {
                authenticated = true;
                tm.removeMessageHandler(this, 0, 255);
                return true;
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 30 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 481..486

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (ar[0] == Packets.SSH_MSG_USERAUTH_SUCCESS)
        {
            authenticated = true;
            tm.removeMessageHandler(this, 0, 255);
            return true;
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java and 1 other location - About 30 mins to fix
          src/main/java/com/trilead/ssh2/auth/AuthenticationManager.java on lines 149..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status