Sign upLogin

connectbot/sshlib

View on GitHub
Star
src/main/java/com/trilead/ssh2/transport/TransportManager.java

Summary

Maintainability
F
5 days
Test Coverage
D
68%

Method receiveLoop has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    public void receiveLoop() throws IOException
    {
        byte[] msg = new byte[35004];

        while (true)
Severity: Minor
Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File TransportManager.java has 469 lines of code (exceeds 250 allowed). Consider refactoring.
Open


package com.trilead.ssh2.transport;

import com.trilead.ssh2.ExtensionInfo;
import com.trilead.ssh2.packets.PacketExtInfo;
Severity: Minor
Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 7 hrs to fix

    Method close has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        public void close(Throwable cause, boolean useDisconnectPacket)
    {
        if (!useDisconnectPacket)
        {
            /* OK, hard shutdown - do not aquire the semaphore,
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method receiveLoop has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void receiveLoop() throws IOException
    {
        byte[] msg = new byte[35004];

        while (true)
    Severity: Major
    Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 3 hrs to fix

      TransportManager has 24 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class TransportManager
{
    private static final Logger log = Logger.getLogger(TransportManager.class);

    class HandlerEntry
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 2 hrs to fix

        Method close has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void close(Throwable cause, boolean useDisconnectPacket)
    {
        if (!useDisconnectPacket)
        {
            /* OK, hard shutdown - do not aquire the semaphore,
        Severity: Major
        Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 2 hrs to fix

          Method initialize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              public void initialize(CryptoWishList cwl, ServerHostKeyVerifier verifier, DHGexParameters dhgex,
            int connectTimeout, SecureRandom rnd, ProxyData proxyData) throws IOException
    {
        /* First, establish the TCP connection to the SSH-2 server */
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void initialize(CryptoWishList cwl, ServerHostKeyVerifier verifier, DHGexParameters dhgex,
            int connectTimeout, SecureRandom rnd, ProxyData proxyData) throws IOException
    {
        /* First, establish the TCP connection to the SSH-2 server */
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 1 hr to fix

            Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                    public void run()
        {
            while (true)
            {
                byte[] msg;
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public void run()
        {
            while (true)
            {
                byte[] msg;
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 1 hr to fix

              Method sendMessage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public void sendMessage(byte[] msg) throws IOException
    {
        if (Thread.currentThread() == receiveThread)
            throw new IOException("Assertion error: sendMessage may never be invoked by the receiver thread!");
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 1 hr to fix

                Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                            public void run()
            {
                try
                {
                    receiveLoop();
                Severity: Minor
                Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method sendMessage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public void sendMessage(byte[] msg) throws IOException
    {
        if (Thread.currentThread() == receiveThread)
            throw new IOException("Assertion error: sendMessage may never be invoked by the receiver thread!");
                Severity: Minor
                Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                                        if ((c >= 32) && (c <= 126))
                            continue;
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 45 mins to fix

                  Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public void initialize(CryptoWishList cwl, ServerHostKeyVerifier verifier, DHGexParameters dhgex,
            int connectTimeout, SecureRandom rnd, ProxyData proxyData) throws IOException
                  Severity: Minor
                  Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java - About 45 mins to fix

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                        for (int i = 0; i < debugMessageBuffer.length(); i++)
                    {
                        char c = debugMessageBuffer.charAt(i);

                        if ((c >= 32) && (c <= 126))
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java and 2 other locations - About 55 mins to fix
                    src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 1590..1597
                    src/main/java/com/trilead/ssh2/transport/TransportManager.java on lines 569..576

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                    for (int i = 0; i < reasonBuffer.length(); i++)
                {
                    char c = reasonBuffer.charAt(i);

                    if ((c >= 32) && (c <= 126))
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/transport/TransportManager.java and 2 other locations - About 55 mins to fix
                    src/main/java/com/trilead/ssh2/channel/ChannelManager.java on lines 1590..1597
                    src/main/java/com/trilead/ssh2/transport/TransportManager.java on lines 614..621

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status