Sign upLogin

consul/consul

View on GitHub
Star
app/models/budget.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class Budget has 39 methods (exceeds 20 allowed). Consider refactoring.
Open

class Budget < ApplicationRecord
  include Measurable
  include Sluggable
  include StatsVersionable
  include Reportable
Severity: Minor
Found in app/models/budget.rb - About 5 hrs to fix

    Method investments_filters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def investments_filters
    [
      ("winners" if finished?),
      ("selected" if publishing_prices_or_later? && !finished?),
      ("unselected" if publishing_prices_or_later?),
    Severity: Minor
    Found in app/models/budget.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Specify a :dependent option. (https://rails.rubystyle.guide#has_many-has_one-dependent-option)
    Open

      has_many :phases, class_name: "Budget::Phase"
    Severity: Minor
    Found in app/models/budget.rb by rubocop

    This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

    Example:

    # bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

    Specify a :dependent option. (https://rails.rubystyle.guide#has_many-has_one-dependent-option)
    Open

      has_one :poll
    Severity: Minor
    Found in app/models/budget.rb by rubocop

    This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

    Example:

    # bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

    There are no issues that match your filters.

    Category
    Status