Sign upLogin

consul/consul

View on GitHub
Star
app/models/legislation/process.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method valid_date_ranges has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def valid_date_ranges
      if end_date && start_date && end_date < start_date
        errors.add(:end_date, :invalid_date_range)
      end
      if debate_end_date && debate_start_date && debate_end_date < debate_start_date
Severity: Minor
Found in app/models/legislation/process.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Specify a :dependent option. (https://rails.rubystyle.guide#has_many-has_one-dependent-option)
Open

  has_one :final_draft_version, -> { where final_version: true, status: "published" },
Severity: Minor
Found in app/models/legislation/process.rb by rubocop

This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

Example:

# bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

There are no issues that match your filters.

Category
Status