Sign upLogin

consul/consul

View on GitHub
Star
app/models/proposal.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Proposal has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

class Proposal < ApplicationRecord
  include Flaggable
  include Taggable
  include Conflictable
  include Measurable
Severity: Minor
Found in app/models/proposal.rb - About 4 hrs to fix

    Specify a :dependent option. (https://rails.rubystyle.guide#has_many-has_one-dependent-option)
    Open

      has_many :polls, as: :related, inverse_of: :related
    Severity: Minor
    Found in app/models/proposal.rb by rubocop

    This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

    Example:

    # bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def self.search_by_code(terms)
    matched_code = match_code(terms)
    results = where(id: matched_code[1]) if matched_code
    results if results.present? && results.first.code == terms
  end
    Severity: Minor
    Found in app/models/proposal.rb and 1 other location - About 15 mins to fix
    app/models/legislation/proposal.rb on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status