consul/consul

View on GitHub

Showing 2,521 of 2,521 total issues

Prefer single quoted strings
Open

      content: image-url("stats_booth.png");
Severity: Minor
Found in app/assets/stylesheets/stats.scss by scss-lint

Nesting should be no greater than 3, but was 4
Open

      &::before {
Severity: Minor
Found in app/assets/stylesheets/stats.scss by scss-lint

Prefer single quoted strings
Open

        content: image-url("stats_booth.png");
Severity: Minor
Found in app/assets/stylesheets/stats.scss by scss-lint

Selector should have depth of applicability no greater than 3, but was 4
Open

    img {

Lists should be surrounded by blank lines
Open

- [ ] Explain why the test is flaky, or under which conditions/scenario it fails randomly

MD032 - Lists should be surrounded by blank lines

Tags: bullet, ul, ol, blank_lines

Aliases: blanks-around-lists

This rule is triggered when lists (of any kind) are either not preceded or not followed by a blank line:

Some text
* Some
* List

1. Some
2. List
Some text

To fix this, ensure that all lists have a blank line both before and after (except where the block is at the beginning or end of the document):

Some text

* Some
* List

1. Some
2. List

Some text

Rationale: Aside from aesthetic reasons, some parsers, including kramdown, will not parse lists that don't have blank lines before and after them.

Note: List items without hanging indents are a violation of this rule; list items with hanging indents are okay:

* This is
not okay

* This is
  okay

Color literals like #f4f8ec should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

      color: color-pick-contrast(#f4f8ec);

Color literals like #92ba48 should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

        background: #92ba48;

0.2 should be written without a leading zero as .2
Open

        margin-right: 0.2em;

Nesting should be no greater than 3, but was 4
Open

      &.mail::before {
Severity: Minor
Found in app/assets/stylesheets/stats.scss by scss-lint

First header should be a top level header
Open

### User Story
Severity: Info
Found in .github/ISSUE_TEMPLATE.md by markdownlint

MD002 - First header should be a top level header

Tags: headers

Aliases: first-header-h1

Parameters: level (number; default 1)

This rule is triggered when the first header in the document isn't a h1 header:

## This isn't a H1 header

### Another header

The first header in the document should be a h1 header:

# Start with a H1 header

## Then use a H2 for subsections

Multiple consecutive blank lines
Open


Severity: Info
Found in .github/ISSUE_TEMPLATE.md by markdownlint

MD012 - Multiple consecutive blank lines

Tags: whitespace, blank_lines

Aliases: no-multiple-blanks

This rule is triggered when there are multiple consecutive blank lines in the document:

Some text here


Some more text here

To fix this, delete the offending lines:

Some text here

Some more text here

Note: this rule will not be triggered if there are multiple consecutive blank lines inside code blocks.

Headers should be surrounded by blank lines
Open

### Current Behavior
Severity: Info
Found in .github/ISSUE_TEMPLATE.md by markdownlint

MD022 - Headers should be surrounded by blank lines

Tags: headers, blank_lines

Aliases: blanks-around-headers

This rule is triggered when headers (any style) are either not preceded or not followed by a blank line:

# Header 1
Some text

Some more text
## Header 2

To fix this, ensure that all headers have a blank line both before and after (except where the header is at the beginning or end of the document):

# Header 1

Some text

Some more text

## Header 2

Rationale: Aside from aesthetic reasons, some parsers, including kramdown, will not parse headers that don't have a blank line before, and will parse them as regular text.

TODO found
Open

    voters.where(origin: "letter").count # TODO: count only valid votes
Severity: Minor
Found in app/models/poll/stats.rb by fixme

TODO found
Open

    0 # TODO
Severity: Minor
Found in app/models/poll/stats.rb by fixme

TODO found
Open

  # TODO: replace with config.log_file_size after upgrading to Rails 7.1
Severity: Minor
Found in config/environments/test.rb by fixme

TODO found
Open

# TODO: safe to remove after upgrading to Rails 7.1 or releasing a new

TODO found
Open

  # TODO: replace with config.log_file_size after upgrading to Rails 7.1
Severity: Minor
Found in config/environments/development.rb by fixme

TODO found
Open

module ActiveRecord # TODO: Remove after upgrading ros-apartment
Severity: Minor
Found in config/initializers/apartment.rb by fixme

TODO found
Open

    0 # TODO
Severity: Minor
Found in app/models/poll/stats.rb by fixme

TODO found
Open

# TODO: remove once we upgrade Foundation and Font Awesome
Severity: Minor
Found in config/initializers/sass.rb by fixme
Severity
Category
Status
Source
Language