consul/consul

View on GitHub
spec/models/legislation/process_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

File process_spec.rb has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "rails_helper"

describe Legislation::Process do
  let(:process) { create(:legislation_process) }

Severity: Minor
Found in spec/models/legislation/process_spec.rb - About 3 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      describe "milestone_tags" do
        context "without milestone_tags" do
          let(:process) { create(:legislation_process) }
    
          it "do not have milestone_tags" do
    Severity: Major
    Found in spec/models/legislation/process_spec.rb and 2 other locations - About 1 hr to fix
    spec/models/budget/investment_spec.rb on lines 1424..1444
    spec/models/proposal_spec.rb on lines 1047..1067

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it "is valid if start dates are missing and the phase is disabled" do
          draft_disabled = build(:legislation_process,
                                 draft_phase_enabled: false,
                                 draft_start_date: nil)
    
    
    Severity: Major
    Found in spec/models/legislation/process_spec.rb and 1 other location - About 1 hr to fix
    spec/models/legislation/process_spec.rb on lines 108..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it "is valid if end dates are missing and the phase is disabled" do
          draft_disabled = build(:legislation_process,
                                 draft_phase_enabled: false,
                                 draft_end_date: nil)
    
    
    Severity: Major
    Found in spec/models/legislation/process_spec.rb and 1 other location - About 1 hr to fix
    spec/models/legislation/process_spec.rb on lines 85..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if draft_end_date is before draft_start_date" do
          process = build(:legislation_process, draft_start_date: Date.current,
                                                draft_end_date: Date.current - 1.day)
          expect(process).not_to be_valid
          expect(process.errors.messages[:draft_end_date])
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 25 mins to fix
    spec/models/legislation/process_spec.rb on lines 160..164
    spec/models/legislation/process_spec.rb on lines 179..184
    spec/models/legislation/process_spec.rb on lines 201..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if end_date is before start_date" do
          process = build(:legislation_process, start_date: Date.current,
                                                end_date: Date.current - 1.day)
          expect(process).not_to be_valid
          expect(process.errors.messages[:end_date]).to include("must be on or after the start date")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 25 mins to fix
    spec/models/legislation/process_spec.rb on lines 179..184
    spec/models/legislation/process_spec.rb on lines 193..198
    spec/models/legislation/process_spec.rb on lines 201..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if debate_end_date is before debate_start_date" do
          process = build(:legislation_process, debate_start_date: Date.current,
                                                debate_end_date: Date.current - 1.day)
          expect(process).not_to be_valid
          expect(process.errors.messages[:debate_end_date])
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 25 mins to fix
    spec/models/legislation/process_spec.rb on lines 160..164
    spec/models/legislation/process_spec.rb on lines 193..198
    spec/models/legislation/process_spec.rb on lines 201..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if allegations_end_date is before allegations_start_date" do
          process = build(:legislation_process, allegations_start_date: Date.current,
                                                allegations_end_date: Date.current - 1.day)
          expect(process).not_to be_valid
          expect(process.errors.messages[:allegations_end_date])
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 25 mins to fix
    spec/models/legislation/process_spec.rb on lines 160..164
    spec/models/legislation/process_spec.rb on lines 179..184
    spec/models/legislation/process_spec.rb on lines 193..198

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if debate phase is enabled but debate_end_date is not present" do
          process = build(:legislation_process, debate_phase_enabled: true, debate_end_date: "")
    
          expect(process).not_to be_valid
          expect(process.errors.messages[:debate_end_date]).to include("can't be blank")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 35..39
    spec/models/legislation/process_spec.rb on lines 63..67
    spec/models/legislation/process_spec.rb on lines 78..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if allegations phase is enabled but allegations_start_date is not present" do
          process = build(:legislation_process, allegations_phase_enabled: true,
                                                allegations_start_date: nil,)
    
          expect(process).not_to be_valid
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 28..32
    spec/models/legislation/process_spec.rb on lines 42..46
    spec/models/legislation/process_spec.rb on lines 56..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if debate phase is enabled but debate_start_date is not present" do
          process = build(:legislation_process, debate_phase_enabled: true, debate_start_date: nil)
    
          expect(process).not_to be_valid
          expect(process.errors.messages[:debate_start_date]).to include("can't be blank")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 28..32
    spec/models/legislation/process_spec.rb on lines 56..60
    spec/models/legislation/process_spec.rb on lines 70..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if proposals phase is enabled but proposals_phase_start_date is not present" do
          process = build(:legislation_process, proposals_phase_enabled: true, proposals_phase_start_date: nil)
    
          expect(process).not_to be_valid
          expect(process.errors.messages[:proposals_phase_start_date]).to include("can't be blank")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 28..32
    spec/models/legislation/process_spec.rb on lines 42..46
    spec/models/legislation/process_spec.rb on lines 70..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if draft is enabled but draft_start_date is not present" do
          process = build(:legislation_process, draft_phase_enabled: true, draft_start_date: nil)
    
          expect(process).not_to be_valid
          expect(process.errors.messages[:draft_start_date]).to include("can't be blank")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 42..46
    spec/models/legislation/process_spec.rb on lines 56..60
    spec/models/legislation/process_spec.rb on lines 70..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if proposals phase is enabled but proposals_phase_end_date is not present" do
          process = build(:legislation_process, proposals_phase_enabled: true, proposals_phase_end_date: "")
    
          expect(process).not_to be_valid
          expect(process.errors.messages[:proposals_phase_end_date]).to include("can't be blank")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 35..39
    spec/models/legislation/process_spec.rb on lines 49..53
    spec/models/legislation/process_spec.rb on lines 78..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if allegations phase is enabled but allegations_end_date is not present" do
          process = build(:legislation_process, allegations_phase_enabled: true, allegations_end_date: "")
    
          expect(process).not_to be_valid
          expect(process.errors.messages[:allegations_end_date]).to include("can't be blank")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 35..39
    spec/models/legislation/process_spec.rb on lines 49..53
    spec/models/legislation/process_spec.rb on lines 63..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "is invalid if draft is enabled but draft_end_date is not present" do
          process = build(:legislation_process, draft_phase_enabled: true, draft_end_date: "")
    
          expect(process).not_to be_valid
          expect(process.errors.messages[:draft_end_date]).to include("can't be blank")
    Severity: Minor
    Found in spec/models/legislation/process_spec.rb and 3 other locations - About 15 mins to fix
    spec/models/legislation/process_spec.rb on lines 49..53
    spec/models/legislation/process_spec.rb on lines 63..67
    spec/models/legislation/process_spec.rb on lines 78..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status