Sign upLogin

consul/consul

View on GitHub
Star
spec/system/admin/banners_spec.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    create(:banner, title: "Ugly banner",
                    description: "Bad text",
                    target_url: "http://www.url.com",
                    post_started_at: (Date.current + 4.days),
                    post_ended_at: (Date.current + 10.days),
Severity: Major
Found in spec/system/admin/banners_spec.rb and 7 other locations - About 15 mins to fix
spec/components/shared/banner_component_spec.rb on lines 5..12
spec/system/admin/banners_spec.rb on lines 6..12
spec/system/admin/banners_spec.rb on lines 14..20
spec/system/admin/banners_spec.rb on lines 22..28
spec/system/admin/banners_spec.rb on lines 30..36
spec/system/admin/banners_spec.rb on lines 38..44
spec/system/admin/banners_spec.rb on lines 125..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      create(:banner, title: "Banner number four",
                      description: "This is the text of banner number four",
                      target_url: "http://www.url.com",
                      post_started_at: (Date.current - 10.days),
                      post_ended_at: (Date.current + 10.days),
Severity: Major
Found in spec/system/admin/banners_spec.rb and 7 other locations - About 15 mins to fix
spec/components/shared/banner_component_spec.rb on lines 5..12
spec/system/admin/banners_spec.rb on lines 6..12
spec/system/admin/banners_spec.rb on lines 14..20
spec/system/admin/banners_spec.rb on lines 22..28
spec/system/admin/banners_spec.rb on lines 38..44
spec/system/admin/banners_spec.rb on lines 125..131
spec/system/admin/banners_spec.rb on lines 164..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      create(:banner, title: "Banner number one",
                      description: "This is the text of banner number one and is not active yet",
                      target_url: "http://www.url.com",
                      post_started_at: (Date.current + 4.days),
                      post_ended_at: (Date.current + 10.days),
Severity: Major
Found in spec/system/admin/banners_spec.rb and 7 other locations - About 15 mins to fix
spec/components/shared/banner_component_spec.rb on lines 5..12
spec/system/admin/banners_spec.rb on lines 14..20
spec/system/admin/banners_spec.rb on lines 22..28
spec/system/admin/banners_spec.rb on lines 30..36
spec/system/admin/banners_spec.rb on lines 38..44
spec/system/admin/banners_spec.rb on lines 125..131
spec/system/admin/banners_spec.rb on lines 164..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      create(:banner, title: "Banner number three",
                      description: "This is the text of banner number three",
                      target_url: "http://www.url.com",
                      post_started_at: (Date.current - 1.day),
                      post_ended_at: (Date.current + 10.days),
Severity: Major
Found in spec/system/admin/banners_spec.rb and 7 other locations - About 15 mins to fix
spec/components/shared/banner_component_spec.rb on lines 5..12
spec/system/admin/banners_spec.rb on lines 6..12
spec/system/admin/banners_spec.rb on lines 14..20
spec/system/admin/banners_spec.rb on lines 30..36
spec/system/admin/banners_spec.rb on lines 38..44
spec/system/admin/banners_spec.rb on lines 125..131
spec/system/admin/banners_spec.rb on lines 164..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    create(:banner, title: "Hello",
                    description: "Wrong text",
                    target_url: "http://www.url.com",
                    post_started_at: (Date.current + 4.days),
                    post_ended_at: (Date.current + 10.days),
Severity: Major
Found in spec/system/admin/banners_spec.rb and 7 other locations - About 15 mins to fix
spec/components/shared/banner_component_spec.rb on lines 5..12
spec/system/admin/banners_spec.rb on lines 6..12
spec/system/admin/banners_spec.rb on lines 14..20
spec/system/admin/banners_spec.rb on lines 22..28
spec/system/admin/banners_spec.rb on lines 30..36
spec/system/admin/banners_spec.rb on lines 38..44
spec/system/admin/banners_spec.rb on lines 164..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      create(:banner, title: "Banner number two",
                      description: "This is the text of banner number two and is not longer active",
                      target_url: "http://www.url.com",
                      post_started_at: (Date.current - 10.days),
                      post_ended_at: (Date.current - 3.days),
Severity: Major
Found in spec/system/admin/banners_spec.rb and 7 other locations - About 15 mins to fix
spec/components/shared/banner_component_spec.rb on lines 5..12
spec/system/admin/banners_spec.rb on lines 6..12
spec/system/admin/banners_spec.rb on lines 22..28
spec/system/admin/banners_spec.rb on lines 30..36
spec/system/admin/banners_spec.rb on lines 38..44
spec/system/admin/banners_spec.rb on lines 125..131
spec/system/admin/banners_spec.rb on lines 164..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      create(:banner, title: "Banner number five",
                      description: "This is the text of banner number five",
                      target_url: "http://www.url.com",
                      post_started_at: (Date.current - 10.days),
                      post_ended_at: (Date.current + 10.days),
Severity: Major
Found in spec/system/admin/banners_spec.rb and 7 other locations - About 15 mins to fix
spec/components/shared/banner_component_spec.rb on lines 5..12
spec/system/admin/banners_spec.rb on lines 6..12
spec/system/admin/banners_spec.rb on lines 14..20
spec/system/admin/banners_spec.rb on lines 22..28
spec/system/admin/banners_spec.rb on lines 30..36
spec/system/admin/banners_spec.rb on lines 125..131
spec/system/admin/banners_spec.rb on lines 164..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status