Sign upLogin

contartecTeam/generic-redis-cache

View on GitHub
Star

Showing 42 of 42 total issues

File GenericRedisCache.js has 748 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

const redis = global.redisInstance

const RedisKeyTypeEnum = require('../enums/RedisKeyTypeEnum')
Severity: Major
Found in lib/services/GenericRedisCache.js - About 1 day to fix

    GenericRedisCache has 46 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class GenericRedisCache {

  /**
   * Default attrs to define the `cache` model
   *
    Severity: Minor
    Found in lib/services/GenericRedisCache.js - About 6 hrs to fix

      Function delete has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

        static async delete(keys) {
    try {
      let deletedValues = []

      if (this.isKeyValid(keys)) {
      Severity: Minor
      Found in lib/services/GenericRedisCache.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _getKeysNotCached has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

        static async _getKeysNotCached(keys, objects) {
    let keysNotCached = []

    if (keys) {
      if (keys.constructor.name == 'Object') {
      Severity: Minor
      Found in lib/services/GenericRedisCache.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getKeyName has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

        static getKeyName(key) {
    const idsIndexes = GenericRedisCache
      .getIdIndexes(this.ATTRS.keyName)

    let keyName = null
      Severity: Minor
      Found in lib/services/GenericRedisCache.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getKeyName has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static getKeyName(key) {
    const idsIndexes = GenericRedisCache
      .getIdIndexes(this.ATTRS.keyName)

    let keyName = null
      Severity: Major
      Found in lib/services/GenericRedisCache.js - About 2 hrs to fix

        Function setList has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

          static async setList(objects) {
    try {
      let redisResponse = null

      if (!(objects instanceof Array))
        Severity: Minor
        Found in lib/services/GenericRedisCache.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _getKeysNotCached has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static async _getKeysNotCached(keys, objects) {
    let keysNotCached = []

    if (keys) {
      if (keys.constructor.name == 'Object') {
        Severity: Major
        Found in lib/services/GenericRedisCache.js - About 2 hrs to fix

          Function getKeyNamesObjects has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            static getKeyNamesObjects(object, ids) {
    const keyNameObjects = []
    if (object && object.constructor.name == 'Object' && ids instanceof Array) {
      if (ids.length && ids[0].constructor.name == 'Object' ) {
        const paramsKeys = Object.keys(object)
          Severity: Major
          Found in lib/services/GenericRedisCache.js - About 2 hrs to fix

            Function set has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              static async set(key, value = undefined, jsonPath = GenericJSONCache.DEFAULT_PATH, commands = redis) {
    try {
      let redisResponse = null

      if (this.isKeyValid(key)) {
            Severity: Minor
            Found in lib/services/GenericRedisCache.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function delete has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              static async delete(keys) {
    try {
      let deletedValues = []

      if (this.isKeyValid(keys)) {
            Severity: Minor
            Found in lib/services/GenericRedisCache.js - About 1 hr to fix

              Function getKeyNames has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                static async getKeyNames(keys) {
    let keyNames = []

    if (keys) {
      if (
              Severity: Minor
              Found in lib/services/GenericRedisCache.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getKeyNames has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                static async getKeyNames(keys) {
    let keyNames = []

    if (keys) {
      if (
              Severity: Minor
              Found in lib/services/GenericRedisCache.js - About 1 hr to fix

                Function getListCache has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                  static async getListCache(keyNames, fields, commands = redis) {
    const cachedValues = []

    if (keyNames && !(keyNames instanceof Array))
      keyNames = [keyNames]
                Severity: Minor
                Found in lib/services/types/GenericHASHCache.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function setCache has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                  static setCache(keyName, value, attr = DEFAULT_PATH, commands = redis) {
    let command = null
    let valueTemp = value

    if (keyName) {
                Severity: Minor
                Found in lib/services/types/GenericJSONCache.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function setList has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  static async setList(objects) {
    try {
      let redisResponse = null

      if (!(objects instanceof Array))
                Severity: Minor
                Found in lib/services/GenericRedisCache.js - About 1 hr to fix

                  Function getKeyAttrId has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                    static getKeyAttrId(key, idAttr) {
    const idValue = key[idAttr.id]

    let value = null
                  Severity: Minor
                  Found in lib/services/GenericRedisCache.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              else {
              chars[indexKeyName] = this.ATTRS.ids[index].idUndefined ?
                this.ATTRS.ids[index].idUndefined :
                this.ATTRS.idUndefined
            }
                  Severity: Major
                  Found in lib/services/GenericRedisCache.js and 1 other location - About 1 hr to fix
                  lib/services/GenericRedisCache.js on lines 311..315

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function get has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                    static async get(key, params) {
    try {
      let cacheObject = await this
        .getCache(key, params)
                  Severity: Minor
                  Found in lib/services/GenericRedisCache.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          .forEach((indexKeyName, index) =>  {
          chars[indexKeyName] = this.ATTRS.ids[index].idUndefined ?
            this.ATTRS.ids[index].idUndefined :
            this.ATTRS.idUndefined
        })
                  Severity: Major
                  Found in lib/services/GenericRedisCache.js and 1 other location - About 1 hr to fix
                  lib/services/GenericRedisCache.js on lines 266..270

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language