conversant/ad-libs.js

View on GitHub
lib/dom/appendHtml.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function appendHtml has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

var appendHtml = function(parentEl, html) {
    if (!(parentEl && parentEl.appendChild)) {
        return [new Error('parentEl is not an Element')];
    }

Severity: Minor
Found in lib/dom/appendHtml.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function appendHtml has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var appendHtml = function(parentEl, html) {
    if (!(parentEl && parentEl.appendChild)) {
        return [new Error('parentEl is not an Element')];
    }

Severity: Minor
Found in lib/dom/appendHtml.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        for (i = 0; i < len; i++) {
                            clonedScript.setAttribute(
                                childEl.attributes[i].name, childEl.attributes[i].value);
                        }
    Severity: Major
    Found in lib/dom/appendHtml.js - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status