Sign upLogin

conversant/ad-libs.js

View on GitHub
Star

Showing 84 of 84 total issues

Function detect has a Cognitive Complexity of 111 (exceeds 5 allowed). Consider refactoring.
Open

var detect = function (win, userAgent) {

    var detectedBrowser = new Browser(),
        browserType = '',
        w = win || window,
Severity: Minor
Found in lib/detect/browser.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File browser.js has 782 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

/**
 * @module Browser
 * @desc Browser Detection - Gets Data Pertaining to User's Browser and OS
Severity: Major
Found in lib/detect/browser.js - About 1 day to fix

    Function detect has 232 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var detect = function (win, userAgent) {

    var detectedBrowser = new Browser(),
        browserType = '',
        w = win || window,
    Severity: Major
    Found in lib/detect/browser.js - About 1 day to fix

      Function MeasurePerformance has 122 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var MeasurePerformance = function () {

    var self = this;

    var w = window,
      Severity: Major
      Found in lib/measurePerformance.js - About 4 hrs to fix

        Function getChromiumVersion has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

        var getChromiumVersion = function (win, uaVersion) {

    var chromiumVersion = DEFAULT_VERSION;
    // no session history management - version 4 - api
    // geolocation - version 5 - api
        Severity: Minor
        Found in lib/detect/browser.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function detect has 103 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var detect = function (win) {
    win = win || window;

    var document = win.document,
        top = win.top,
        Severity: Major
        Found in lib/detect/capabilities.js - About 4 hrs to fix

          Function detect has 96 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var detect = function () {

    var environment = {},
        zoomRatio = 1,
        deviceWidth,
          Severity: Major
          Found in lib/detect/environment.js - About 3 hrs to fix

            Function detect has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
            Open

            var detect = function () {

    var environment = {},
        zoomRatio = 1,
        deviceWidth,
            Severity: Minor
            Found in lib/detect/environment.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                } else if (browserType === TYPE.OPERA_MINI) {
        detectedBrowser = getOsFromUa(w, ua);
        detectedBrowser.name = 'Opera Mini';
        detectedBrowser.ua.version = parseIntIfMatch(ua, /Opera Mini\/(\d+)/i, 10); // we trust the UA for now
        detectedBrowser.version = detectedBrowser.ua.version;
            Severity: Major
            Found in lib/detect/browser.js and 4 other locations - About 3 hrs to fix
            lib/detect/browser.js on lines 1191..1246
            lib/detect/browser.js on lines 1198..1246
            lib/detect/browser.js on lines 1205..1246
            lib/detect/browser.js on lines 1223..1246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                } else if (browserType === TYPE.FIREFOX_MOBILE) {
        detectedBrowser = getOsFromUa(w, ua);
        detectedBrowser.name = 'Firefox Android';
        detectedBrowser.ua.version = parseIntIfMatch(ua, /Firefox\/(\d+)/i, 10); // we trust the UA for now
        detectedBrowser.version = detectedBrowser.ua.version;
            Severity: Major
            Found in lib/detect/browser.js and 4 other locations - About 3 hrs to fix
            lib/detect/browser.js on lines 1191..1246
            lib/detect/browser.js on lines 1205..1246
            lib/detect/browser.js on lines 1216..1246
            lib/detect/browser.js on lines 1223..1246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                } else if (browserType === TYPE.OPERA_ANDROID) {
        detectedBrowser = getOsFromUa(w, ua);
        detectedBrowser.name = 'Opera Android';
        detectedBrowser.ua.version = parseIntIfMatch(ua, /Opera\/(\d+)/i, 10); // we trust the UA for now
        detectedBrowser.version = detectedBrowser.ua.version;
            Severity: Major
            Found in lib/detect/browser.js and 4 other locations - About 3 hrs to fix
            lib/detect/browser.js on lines 1191..1246
            lib/detect/browser.js on lines 1198..1246
            lib/detect/browser.js on lines 1205..1246
            lib/detect/browser.js on lines 1216..1246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                } else if (browserType === TYPE.CHROME_MOBILE) {
        detectedBrowser = getOsFromUa(w, ua);
        detectedBrowser.name = 'Chrome Android';
        detectedBrowser.ua.version = parseIntIfMatch(ua, /Chrome\/(\d+)/i, 10); // we trust the UA for now
        detectedBrowser.version = detectedBrowser.ua.version;
            Severity: Major
            Found in lib/detect/browser.js and 4 other locations - About 3 hrs to fix
            lib/detect/browser.js on lines 1198..1246
            lib/detect/browser.js on lines 1205..1246
            lib/detect/browser.js on lines 1216..1246
            lib/detect/browser.js on lines 1223..1246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                } else if (browserType === TYPE.MICROSOFT_MOBILE) {
        detectedBrowser = getMicrosoftOS(w, ua);
        detectedBrowser.name = 'Mobile IE';
        detectedBrowser.ua.version = parseIntIfMatch(ua, /IEMobile\/(\d+)/i, 10); // we trust the UA for now
        detectedBrowser.version = detectedBrowser.ua.version;
            Severity: Major
            Found in lib/detect/browser.js and 4 other locations - About 3 hrs to fix
            lib/detect/browser.js on lines 1191..1246
            lib/detect/browser.js on lines 1198..1246
            lib/detect/browser.js on lines 1216..1246
            lib/detect/browser.js on lines 1223..1246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getGeckoVersion has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
            Open

            var getGeckoVersion = function (win, uaVersion) {

    var geckoVersion = DEFAULT_VERSION,
        d = win.document,
        nav = win.navigator;
            Severity: Minor
            Found in lib/detect/browser.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function MeasurePerformance has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
            Open

            var MeasurePerformance = function () {

    var self = this;

    var w = window,
            Severity: Minor
            Found in lib/measurePerformance.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function appendHtml has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
            Open

            var appendHtml = function(parentEl, html) {
    if (!(parentEl && parentEl.appendChild)) {
        return [new Error('parentEl is not an Element')];
    }
            Severity: Minor
            Found in lib/dom/appendHtml.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function PerfMarker has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
            Open

            var PerfMarker = function () {

    var self = this,
        timeMap = {},
        timeline = [];
            Severity: Minor
            Found in lib/performanceMarker.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getMicrosoftOS has 75 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            var getMicrosoftOS = function (win, ua) {

    var microsoftBrowser = new Browser();

    if (looksLike(/XBox One/i, ua)) {
            Severity: Major
            Found in lib/detect/browser.js - About 3 hrs to fix

              Function PerfMarker has 68 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              var PerfMarker = function () {

    var self = this,
        timeMap = {},
        timeline = [];
              Severity: Major
              Found in lib/performanceMarker.js - About 2 hrs to fix

                Function domReady has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                Open

                var domReady = function (callback, targetWindow, isInteractiveOk) {

    // Local variables, because domReady should work for more than just the parent document/window
    var hasLoaded = false,
        pollingTimeoutHandle,
                Severity: Minor
                Found in lib/dom/domReady.js - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language