Sign upLogin

conveyal/modeify

View on GitHub
Star
client/components/conveyal/transitive.js/master/lib/core/network.js

Summary

Maintainability
D
2 days
Test Coverage

File network.js has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var each = require('each');
var debug = require('debug')('transitive:network');
var Emitter = require('emitter');

var NetworkPath = require('./path');
Severity: Minor
Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 5 hrs to fix

    Function load has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Network.prototype.load = function(data) {
  debug('loading', data);
  var self = this;

  // check data
    Severity: Major
    Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 3 hrs to fix

      Function load has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      Network.prototype.load = function(data) {
  debug('loading', data);
  var self = this;

  // check data
      Severity: Minor
      Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function populateGraphEdges has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Network.prototype.populateGraphEdges = function() {
  var self = this;
  // vertex associated with the last vertex point we passed in this sequence
  var lastVertex = null;
      Severity: Minor
      Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 1 hr to fix

        Function createInternalVertexPoints has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        Network.prototype.createInternalVertexPoints = function() {

  this.internalVertexPoints = [];

  for (var i in this.graph.edgeGroups) {
        Severity: Minor
        Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function annotateTransitPoints has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Network.prototype.annotateTransitPoints = function() {
  var lookup = {};

  this.paths.forEach(function(path) {
        Severity: Minor
        Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 1 hr to fix

          Function createRenderedSegments has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Network.prototype.createRenderedSegments = function() {
  this.reLookup = {};
  this.renderedEdges = [];
  this.renderedSegments = [];
          Severity: Minor
          Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 1 hr to fix

            Function createRenderedEdge has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Network.prototype.createRenderedEdge = function(pathSegment, gEdge, forward, patterns) {
  var rEdge;

  // construct the edge key, disregarding mode qualifiers (e.g. "_RENT")
  var type = pathSegment.getType().split('_')[0];
            Severity: Minor
            Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 1 hr to fix

              Function createGraphEdge has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              Network.prototype.createGraphEdge = function(segment, fromVertex, toVertex, internalPoints, geomCoords) {
              Severity: Minor
              Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 35 mins to fix

                Function createRenderedEdge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                Network.prototype.createRenderedEdge = function(pathSegment, gEdge, forward, patterns) {
  var rEdge;

  // construct the edge key, disregarding mode qualifiers (e.g. "_RENT")
  var type = pathSegment.getType().split('_')[0];
                Severity: Minor
                Found in client/components/conveyal/transitive.js/master/lib/core/network.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                Network.prototype.addVertexPoint = function(point) {
  if (this.baseVertexPoints.indexOf(point) !== -1) return;
  this.baseVertexPoints.push(point);
};
                Severity: Major
                Found in client/components/conveyal/transitive.js/master/lib/core/network.js and 1 other location - About 1 hr to fix
                client/components/conveyal/transitive.js/master/lib/graph/edge.js on lines 146..149

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status