Sign upLogin

conveyal/modeify

View on GitHub
Star

Showing 580 of 580 total issues

Function convertOtpData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

Profiler.prototype.convertOtpData = function(opts) {
  var self = this;
  self.data = {
    journeys: [],
    patterns: [],
Severity: Minor
Found in client/components/conveyal/otp-profiler/master/index.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

View.prototype.save = function (e) {
  debug('save')
  var data = serialize(this.el)

  if (!data.internalId && !data.email) {
Severity: Minor
Found in client/commuter-form/index.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function requestPlan has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

module.exports.requestPlan = function (plan) {
  if (config.r5 || process.env.TEST_R5_URL) {
    const r5Url = config.r5 ? config.r5.url : process.env.TEST_R5_URL
    const timezoneName = geoTz.tz(plan.from.lat, plan.from.lon)
    if (!timezoneName) {
Severity: Minor
Found in lib/r5.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  setTimeout(function () {
    if (!nextd) {
      req.otp = 'Timed out'
      nextd = true
      next()
Severity: Minor
Found in lib/health.js and 1 other location - About 35 mins to fix
lib/health.js on lines 59..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (edge.bikeRentalOnStation) {
      currentLeg = bikeRentalEdges
      onStationEndpoint = constructPlaceEndpoint(`bicycle_rent_station_${edge.bikeRentalOnStation.id}`)
    }
Severity: Minor
Found in lib/plan/profile-to-transitive.js and 1 other location - About 35 mins to fix
lib/plan/profile-to-transitive.js on lines 218..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (edge.bikeRentalOffStation) {
      currentLeg = postWalkEdges
      offStationEndpoint = constructPlaceEndpoint(`bicycle_rent_station_${edge.bikeRentalOffStation.id}`)
    }
Severity: Minor
Found in lib/plan/profile-to-transitive.js and 1 other location - About 35 mins to fix
lib/plan/profile-to-transitive.js on lines 223..226

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  setTimeout(function () {
    if (!nextd) {
      req.geocoder = 'Timed out'
      nextd = true
      next()
Severity: Minor
Found in lib/health.js and 1 other location - About 35 mins to fix
lib/health.js on lines 85..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    if (b.point && b.point.getType() === 'STOP') return 1;
Severity: Major
Found in client/components/conveyal/transitive.js/master/lib/graph/index.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        if (a.point && a.point.getType() === 'STOP') return -1;
    Severity: Major
    Found in client/components/conveyal/transitive.js/master/lib/graph/index.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if ('string' == typeof key) return get(key);
      Severity: Major
      Found in client/components/yields/store/master/index.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if ('object' == typeof key) return each(key, set);
        Severity: Major
        Found in client/components/yields/store/master/index.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return false;
          Severity: Major
          Found in client/components/visionmedia/superagent/v1.1.0/lib/client.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return '#333'
            Severity: Major
            Found in client/convert/index.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return {
        x: this.labelAnchor.x,
        y: this.labelAnchor.y - bboxSide,
        width: bboxSide,
        height: bboxSide
              Severity: Major
              Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return {
        x: this.labelAnchor.x - bboxSide,
        y: this.labelAnchor.y - bboxSide,
        width: bboxSide,
        height: bboxSide
                Severity: Major
                Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return {
        x: this.labelAnchor.x - bboxSide,
        y: this.labelAnchor.y,
        width: bboxSide,
        height: bboxSide
                  Severity: Major
                  Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return {
        x: this.labelAnchor.x,
        y: this.labelAnchor.y,
        width: bboxSide,
        height: bboxSide
                    Severity: Major
                    Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          if (link && link.indexOf('mailto:') > -1) return;
                      Severity: Major
                      Found in client/components/visionmedia/page.js/1.6.1/index.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            if (!hashbang && el.pathname === location.pathname && (el.hash || '#' === link)) return;
                        Severity: Major
                        Found in client/components/visionmedia/page.js/1.6.1/index.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                            return ms + 'ms';
                          Severity: Major
                          Found in client/components/rauchg/ms.js/0.7.0/index.js - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language